Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent funding explicit ethereum addresses on consensus #31

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

matevz
Copy link
Member

@matevz matevz commented Feb 22, 2023

Fixes #23 .

Depends on #11.

Before:

$ oasis accounts transfer 0.1 0xDce075E1C39b1ae0b75D554558b6451A226ffe12 --no-paratime
You are about to sign the following transaction:
Method: staking.Transfer
Body:
  To:     oasis1qqxlf9za3py8d6462wkwm49r4t294slncy97zhlr
  Amount: 0.1 TEST
Nonce:  7
Fee:
  Amount: 0.0 TEST
  Gas limit: 1264
  (gas price: 0.0 TEST per gas unit)

Network:  testnet
ParaTime: none (consensus layer)
Account:  test

$ oasis accounts withdraw 0.1 0xDce075E1C39b1ae0b75D554558b6451A226ffe12
You are about to sign the following transaction:
Format: plain
Method: consensus.Withdraw
Body:
  To: oasis1qqxlf9za3py8d6462wkwm49r4t294slncy97zhlr
  Amount: 0.1 TEST
Authorized signer(s):
  1. MJ2XCjkj132C9YWpDUSQFjkCTI8bSw8bi0w9EwwE1Bg= (ed25519)
     Nonce: 0
Fee:
  Amount: 0.0011311 TEST
  Gas limit: 11311
  (gas price: 0.0000001 TEST per gas unit)

Network:  testnet
ParaTime: sapphire
Account:  test

After:

$ oasis accounts transfer 0.1 0xDce075E1C39b1ae0b75D554558b6451A226ffe12 --no-paratime
Error: signer for address '0xdCe075E1C39b1AE0b75d554558B6451a226FFE12' will not be able to sign transactions on consensus layer
Use --force to ignore this check
$ oasis accounts withdraw 0.1 0xDce075E1C39b1ae0b75D554558b6451A226ffe12
Error: signer for address '0xdCe075E1C39b1AE0b75d554558B6451a226FFE12' will not be able to sign transactions on consensus layer
Use --force to ignore this check

@matevz matevz changed the base branch from master to matevz/ledger-runtime-support February 22, 2023 13:28
@matevz matevz force-pushed the matevz/ledger-runtime-support branch 6 times, most recently from b281d11 to 5e2d16c Compare February 27, 2023 10:52
@matevz matevz force-pushed the matevz/ledger-runtime-support branch from 5e2d16c to 41a1f28 Compare March 9, 2023 10:35
@matevz matevz force-pushed the matevz/feature/prevent-consensus-eth-address branch from 1740c61 to 28694d3 Compare March 9, 2023 10:36
@matevz matevz force-pushed the matevz/ledger-runtime-support branch 10 times, most recently from bb5e99e to b169980 Compare March 13, 2023 16:06
Base automatically changed from matevz/ledger-runtime-support to master March 13, 2023 16:09
@matevz matevz force-pushed the matevz/feature/prevent-consensus-eth-address branch from 28694d3 to dba2f16 Compare March 14, 2023 10:33
@matevz matevz requested a review from kostko March 14, 2023 10:39
@matevz matevz merged commit 4cc3fe3 into master Mar 14, 2023
@matevz matevz deleted the matevz/feature/prevent-consensus-eth-address branch March 14, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent consensus transfers to eth addresses
2 participants