-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wallet: Implement ADR14 #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matevz
force-pushed
the
matevz/ledger-runtime-support
branch
3 times, most recently
from
January 26, 2023 11:33
e43b2eb
to
4546d91
Compare
matevz
force-pushed
the
matevz/ledger-runtime-support
branch
4 times, most recently
from
February 9, 2023 12:31
f630302
to
8d1f11f
Compare
kostko
reviewed
Feb 9, 2023
matevz
force-pushed
the
matevz/ledger-runtime-support
branch
2 times, most recently
from
February 22, 2023 12:29
d86ec60
to
50e73f6
Compare
matevz
force-pushed
the
matevz/ledger-runtime-support
branch
6 times, most recently
from
February 27, 2023 10:52
b281d11
to
5e2d16c
Compare
matevz
force-pushed
the
matevz/ledger-runtime-support
branch
2 times, most recently
from
March 9, 2023 10:55
41a1f28
to
beacc9a
Compare
kostko
reviewed
Mar 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks mostly good, just some nits and it should be ready to merge!
matevz
force-pushed
the
matevz/ledger-runtime-support
branch
3 times, most recently
from
March 10, 2023 09:33
3862716
to
e5c6e1c
Compare
matevz
force-pushed
the
matevz/ledger-runtime-support
branch
2 times, most recently
from
March 10, 2023 11:25
5abd4e9
to
73df0bc
Compare
kostko
reviewed
Mar 10, 2023
kostko
reviewed
Mar 10, 2023
matevz
force-pushed
the
matevz/ledger-runtime-support
branch
2 times, most recently
from
March 13, 2023 15:50
5138642
to
37c2a08
Compare
matevz
force-pushed
the
matevz/ledger-runtime-support
branch
from
March 13, 2023 15:52
37c2a08
to
bb5e99e
Compare
kostko
approved these changes
Mar 13, 2023
matevz
force-pushed
the
matevz/ledger-runtime-support
branch
from
March 13, 2023 16:06
bb5e99e
to
b169980
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires oasisprotocol/oasis-sdk#1248