Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet: Implement ADR14 #11

Merged
merged 3 commits into from
Mar 13, 2023
Merged

wallet: Implement ADR14 #11

merged 3 commits into from
Mar 13, 2023

Conversation

matevz
Copy link
Member

@matevz matevz commented Jan 23, 2023 •
edited
Loading

Requires oasisprotocol/oasis-sdk#1248

  • Adds support for signing runtime transactions with Ledger
  • Bumps oasis-sdk from 0.3.0 to 0.4.0
  • Adds Migration primitives for wallet config

@matevz matevz mentioned this pull request Jan 25, 2023
Closed
@matevz matevz force-pushed the matevz/ledger-runtime-support branch 3 times, most recently from e43b2eb to 4546d91 Compare January 26, 2023 11:33
@matevz matevz force-pushed the matevz/ledger-runtime-support branch 4 times, most recently from f630302 to 8d1f11f Compare February 9, 2023 12:31
@matevz matevz marked this pull request as ready for review February 9, 2023 12:31
@matevz matevz requested a review from kostko February 9, 2023 12:31
kostko
kostko reviewed Feb 9, 2023
View reviewed changes
cmd/common/transaction.go Outdated Show resolved Hide resolved
@kostko kostko mentioned this pull request Feb 9, 2023
Merged
@matevz matevz requested a review from kostko February 14, 2023 15:51
@matevz matevz force-pushed the matevz/ledger-runtime-support branch 2 times, most recently from d86ec60 to 50e73f6 Compare February 22, 2023 12:29
@matevz matevz mentioned this pull request Feb 22, 2023
Merged
@matevz matevz force-pushed the matevz/ledger-runtime-support branch 6 times, most recently from b281d11 to 5e2d16c Compare February 27, 2023 10:52
@matevz matevz mentioned this pull request Feb 27, 2023
Closed
@matevz matevz force-pushed the matevz/ledger-runtime-support branch 2 times, most recently from 41a1f28 to beacc9a Compare March 9, 2023 10:55
kostko
kostko reviewed Mar 9, 2023
View reviewed changes
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks mostly good, just some nits and it should be ready to merge!

go.mod Outdated Show resolved Hide resolved
wallet/ledger/device.go Outdated Show resolved Hide resolved
wallet/ledger/ledger.go Outdated Show resolved Hide resolved
wallet/ledger/ledger.go Show resolved Hide resolved
@matevz matevz force-pushed the matevz/ledger-runtime-support branch 3 times, most recently from 3862716 to e5c6e1c Compare March 10, 2023 09:33
@matevz matevz mentioned this pull request Mar 10, 2023
Closed
@matevz matevz force-pushed the matevz/ledger-runtime-support branch 2 times, most recently from 5abd4e9 to 73df0bc Compare March 10, 2023 11:25
kostko
kostko reviewed Mar 10, 2023
View reviewed changes
wallet/ledger/ledger.go Outdated Show resolved Hide resolved
kostko
kostko reviewed Mar 10, 2023
View reviewed changes
config/config.go Outdated Show resolved Hide resolved
config/wallet.go Show resolved Hide resolved
config/wallet.go Outdated Show resolved Hide resolved
wallet/ledger/ledger.go Outdated Show resolved Hide resolved
@matevz matevz force-pushed the matevz/ledger-runtime-support branch 2 times, most recently from 5138642 to 37c2a08 Compare March 13, 2023 15:50
@matevz matevz force-pushed the matevz/ledger-runtime-support branch from 37c2a08 to bb5e99e Compare March 13, 2023 15:52
@matevz matevz force-pushed the matevz/ledger-runtime-support branch from bb5e99e to b169980 Compare March 13, 2023 16:06
@matevz matevz enabled auto-merge March 13, 2023 16:07
@matevz matevz merged commit e0205e4 into master Mar 13, 2023
@matevz matevz deleted the matevz/ledger-runtime-support branch March 13, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matevz @kostko