Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd): Store Eth address as reference #65

Merged
merged 2 commits into from May 9, 2023

Conversation

matevz
Copy link
Member

@matevz matevz commented Apr 27, 2023

Requires oasisprotocol/oasis-sdk#1352

Fixes #63 on CLI side.

@kostko
Copy link
Member

kostko commented May 9, 2023

I guess this just needs the version bump from #66.

@matevz matevz force-pushed the matevz/fix/client-go-test-wallet-eth branch 2 times, most recently from 9b48509 to 0d84fa1 Compare May 9, 2023 10:07
@matevz
Copy link
Member Author

matevz commented May 9, 2023

I guess this just needs the version bump from #66.

Yep, works now. Interesting, I couldn't cherry pick the deps bot commit directly, because gitlint complained about the line length of the git message.

Anyway, ready for review.

matevz and others added 2 commits May 9, 2023 12:16
Bumps github.com/oasisprotocol/oasis-sdk/client-sdk/go  from 0.4.0 to 0.5.0.

---
updated-dependencies:
- dependency-name: github.com/oasisprotocol/oasis-sdk/client-sdk/go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@matevz matevz force-pushed the matevz/fix/client-go-test-wallet-eth branch from 0d84fa1 to 0a21fe4 Compare May 9, 2023 10:17
@kostko
Copy link
Member

kostko commented May 9, 2023

I guess this just needs the version bump from #66.

Yep, works now. Interesting, I couldn't cherry pick the deps bot commit directly, because gitlint complained about the line length of the git message.

Anyway, ready for review.

Yes, dependabot is exempt.

@matevz matevz merged commit dabce52 into master May 9, 2023
2 checks passed
@matevz matevz deleted the matevz/fix/client-go-test-wallet-eth branch May 9, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong warning for consensus transfer txes
2 participants