[BREAKING] client-sdk: Fix ETH address format for test accounts #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1352 +/- ##
=======================================
Coverage 56.14% 56.14%
=======================================
Files 120 120
Lines 8522 8522
=======================================
Hits 4785 4785
Misses 3700 3700
Partials 37 37
|
pro-wh
reviewed
Apr 27, 2023
| @@ -58,7 +58,11 @@ func ResolveAddress(net *config.Network, address string) (*types.Address, *ethCo | |||
| case addressExplicitTest: | |||
| // Test key. | |||
| if testKey, ok := testing.TestAccounts[data]; ok { | |||
| return &testKey.Address, &testKey.EthAddress, nil | |||
There was a problem hiding this comment.
what's in testKey.EthAddress if it's not secp256k1eth?
There was a problem hiding this comment.
should we just make the test key struct have a *ethCommon.Address instead then?
pro-wh
approved these changes
Apr 27, 2023
|
what's the codepath that leads to this in the cli though? |
matevz
force-pushed
the
matevz/fix/client-go-test-wallet-eth
branch
from
ab10199
to
44915f4
Compare
|
I cleaned this and use |
matevz
changed the title
matevz
force-pushed
the
matevz/fix/client-go-test-wallet-eth
branch
from
44915f4
to
8218476
Compare
kostko
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ETH address handling for non-secp256k1 test accounts.
Fixes oasisprotocol/cli#63