Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure docs #200

Merged
merged 24 commits into from
Sep 9, 2022
Merged

Restructure docs #200

merged 24 commits into from
Sep 9, 2022

Conversation

matevz
Copy link
Member

@matevz matevz commented Aug 12, 2022

Fixes #184, #125, #203, #10.

New features:

  • adds remark plugin which converts github.com documentation links from various Oasis repos to relative docs links,
  • implements correct Edit page link across all components and repositories,
  • implements cross-component doc cards
  • adds guidelines for writing Oasis docs (docs structure, cross-referencing, using doccards etc.)
  • moves redirects to separate file
  • bumps Docusaurus to v2.1.0

Structural changes:

  • splits documentation into general, get-involved, node, dapp, paratime, and core. Now the chapters are not repository-based anymore (e.g. docs of oasis-sdk git module now became some sections of dapp chapter).
  • all path changes are backward-compatible by adding redirects.
  • moves aforementioned chapter links to the top bar. Support and website links were moved to the top-right corner icon and the footer respectively,
  • removes usage of multiple plugin-content-docs plugins by unifying the site structure and taking docs/ as a site root
  • moves Mainnet and Testnet categories from general to node and Prerequisites, Maintenance, Advanced sections to run-your-node category
  • moves General->Set up your node to Run Node->Run your Node; moves genesis-doc.md from general/manage-tokens to node
  • adds dapp with Emerald and Sapphire tutorials and oasis-sdk/docs/contract for Cipher section
  • adds paratime chapter containing oasis-sdk/docs/runtime files
  • renames all index.md, overview.md, getting-started.md files to README.md. Always open it directly when clicking on the category link. Use generated table of contents with generated-index doc page type, if no feasible information exists.
  • moves token-delivery-and-kyc to get-involved chapter and the remaining general/community-resources to get-involved.
  • moves General->FAQ to General->Oasis network->FAQ

@netlify
Copy link

netlify bot commented Aug 12, 2022

Deploy Preview for trusting-archimedes-14c863 ready!

Name Link
🔨 Latest commit e99e238
🔍 Latest deploy log https://app.netlify.com/sites/trusting-archimedes-14c863/deploys/631b5165a1c3aa00093303ab
😎 Deploy Preview https://deploy-preview-200--trusting-archimedes-14c863.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kostko
Copy link
Member

kostko commented Aug 16, 2022

Nice!

Probably "Oasis Core" should go under "Developers" instead of being its own tab?

@matevz matevz force-pushed the matevz/feature/restructure-docs branch from a4dc867 to ca53e1b Compare August 16, 2022 13:36
@matevz matevz changed the title Matevz/feature/restructure docs Restructure docs Aug 18, 2022
@matevz matevz force-pushed the matevz/feature/restructure-docs branch 2 times, most recently from b709c8f to f95a5ab Compare August 18, 2022 14:12
@matevz matevz marked this pull request as ready for review August 18, 2022 14:12
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the Developers -> Oasis SDK page it seems that the "Oasis Core Runtime Layer" link points to GitHub.

@matevz
Copy link
Member Author

matevz commented Aug 18, 2022

On the Developers -> Oasis SDK page it seems that the "Oasis Core Runtime Layer" link points to GitHub.

I was thinking of solving those in a separate PR #203.

@matevz matevz force-pushed the matevz/feature/restructure-docs branch from f95a5ab to e6df70e Compare August 22, 2022 10:04
@matevz
Copy link
Member Author

matevz commented Aug 22, 2022

On the Developers -> Oasis SDK page it seems that the "Oasis Core Runtime Layer" link points to GitHub.

Now implemented as part of this PR.

@matevz matevz requested review from tjanez and lukaw3d August 22, 2022 13:18
@matevz matevz force-pushed the matevz/feature/restructure-docs branch from b13c226 to 04b6f27 Compare August 22, 2022 13:22
@gw0
Copy link
Contributor

gw0 commented Aug 23, 2022

Because restructuring the docs is a big deal we should not rush it. In general I like the new structure, but I still have a few suggestions.

  • Mainnet Network Parameters and Mainnet Upgrade Logs should probably go into a Mainnet category under Node Operators
  • Testnet Network Parameters and Testnet Upgrade Logs should probably go into a Testnet category under Node Operators
  • Developers / Oasis SDK / Smart Contracts should probably be named Cipher ParaTime (similar to Emerald and Sapphire) and contain the API reference
  • Developers / Oasis SDK / Runtimes should probably have a more informative/call-to-action name, like Your Custom ParaTime or Roll your own ParaTime
  • I suspect we have three different groups of developers: contracts, runtimes, and core (last two could be merged?). Maybe we should rename "Developers" to "Contract Developers" and "Core" into "Core Developers" (and also include Oasis SDK / Runtimes here).

@kostko
Copy link
Member

kostko commented Aug 24, 2022

Developers / Oasis SDK / Smart Contracts should probably be named Cipher ParaTime (similar to Emerald and Sapphire) and contain the API reference

On the other hand this seems weird as the Contract SDK documentation is general for any paratime using the contracts module.

@kostko
Copy link
Member

kostko commented Aug 24, 2022

In case we want to make this Cipher-specific we should probably move these contract docs outside the SDK repository? But then we are left without general contract SDK docs not specific to any paratime deployment?

@kostko
Copy link
Member

kostko commented Aug 24, 2022

I suspect we have three different groups of developers: contracts, runtimes, and core (last two could be merged?). Maybe we should rename "Developers" to "Contract Developers" and "Core" into "Core Developers" (and also include Oasis SDK / Runtimes here).

Agree that the SDK docs should probably be separate, especially if we move out the "Cipher ParaTime" docs? So the SDK contains a bunch of things (as mentioned in the docs):

  • Runtime SDK (for building runtimes)
  • Client SDK (for building clients that talk to runtimes)
  • WASM Contracts SDK (for building smart contracts using the WASM contrats module)

Note that all of these are general and unrelated to any specific runtime/paratime deployment.

But saying "Core Developers" and "Contract Developers" is way too long. In my mind the categories are something like:

  • contracts (evm / confidential evm / wasm),
  • SDK and
  • Core.

So maybe we should move the general WASM contracts section (and related API reference links) out under Contracts -> Cipher if this is possible to do.

@kostko
Copy link
Member

kostko commented Aug 24, 2022

Also one thing that is strange is the "Network Primer" (the "Why Oasis" and "ROSE Token Metrics" links lead there) as it seems like it is a completely separate thing instead of being a section in the main docs. I think it should be merged into the main docs now that we have reduced clutter there.

@kostko
Copy link
Member

kostko commented Aug 24, 2022

  • Mainnet Network Parameters and Mainnet Upgrade Logs should probably go into a Mainnet category under Node Operators
  • Testnet Network Parameters and Testnet Upgrade Logs should probably go into a Testnet category under Node Operators

Yeah this is probably right. Same with the delegation policy.

@gw0
Copy link
Contributor

gw0 commented Aug 24, 2022

Note that all of these are general and unrelated to any specific runtime/paratime deployment.

In my mind the categories are something like:
* contracts (evm / confidential evm / wasm),
* SDK and
* Core.

Makes sense. Initially it has been bugging me that we promote ParaTimes, but then the docs aren't organized around them. But I am beginning to think that it makes a lot of sense to keep node operator and all developer docs paratime-agnostic and focused on the technological/functional aspects.

Lets imagine the following user story: I heard about the confidentiality features (replace with any other feature) of Sapphire (replace with other ParaTime). As a developer I want to develop a smart contract on Sapphire. Where do I start?

Because we promote ParaTimes, the solution would be if each ParaTime has a dedicated category under "General". It should clearly describe what it is (from contribute-to-the-network/run-a-paratime-node) and which technologies are being used with links to relevant developer docs.

@matevz matevz force-pushed the matevz/feature/restructure-docs branch 2 times, most recently from 8d470d9 to 2aff189 Compare August 26, 2022 15:00
@matevz
Copy link
Member Author

matevz commented Aug 29, 2022

The mainnet and testnet categories are now moved under operators/. I also moved prerequisites, maintenance-guides and advanced under set-up-your-node to reduce top-level clutter. Please check.

@kostko
Copy link
Member

kostko commented Aug 29, 2022

Looks like the "Network Parameters" are still in the General sidebar and clicking on it switches to the Node Operators tab.

@matevz
Copy link
Member Author

matevz commented Aug 29, 2022

Looks like the "Network Parameters" are still in the General sidebar and clicking on it switches to the Node Operators tab.

FYI this is deliberate so you can access current network parameters with a single click.

@kostko
Copy link
Member

kostko commented Aug 29, 2022

Why would someone that is not a node operator need to access network parameters?

- also moved delegation-policy.md to contribute-to-the-network/
- moved network-paramters.md to operators/mainnet
…perators/set-up-your-node

- replace generic {prerequisites|maintenance-guides|advanced}/README.md files with generated-index
- move operators/troubleshooting.md to operators/set-up-your-node
- Also rename how-to-transfer-rose-into-evm-paratime -> how-to-transfer-rose-into-paratime
- removes docs/general/manage-tokens/holding-rose-tokens/README.md in favor of autogenerated-index
@matevz matevz force-pushed the matevz/feature/restructure-docs branch from 0b9b14b to 0fc2045 Compare September 9, 2022 11:36
@matevz matevz force-pushed the matevz/feature/restructure-docs branch 2 times, most recently from 7f5887f to dc9708f Compare September 9, 2022 14:31
@matevz matevz force-pushed the matevz/feature/restructure-docs branch from dc9708f to 62f386b Compare September 9, 2022 14:43
@matevz matevz force-pushed the matevz/feature/restructure-docs branch from 62f386b to e99e238 Compare September 9, 2022 14:44
@matevz matevz merged commit f5d1b9c into main Sep 9, 2022
@matevz matevz deleted the matevz/feature/restructure-docs branch September 9, 2022 14:51
Copy link
Member

@tjanez tjanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @matevz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs/dev: Split out the developer parts of general docs into its own group
6 participants