Consensus dashboard account list card #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
buberdds
commented
Jan 18, 2024
•
buberdds
commented
Deployed to Cloudflare Pages
|
buberdds
force-pushed
the
mz/consensusDashboardAccountList
branch
7 times, most recently
from
9d4f66e
to
870d546
Compare
lukaw3d
reviewed
Jan 19, 2024
src/oasis-nexus/api.ts
Outdated
Comment on lines
805
to
931
| // TODO: remove when API returns total, looking at query filters we store that data in Nexus | ||
| const total = BigInt(account.available) + BigInt(account.escrow) + BigInt(account.debonding) |
There was a problem hiding this comment.
This calculation is wrong. API does not return the correct fields, and debonding is named misleadingly. History of wrong math: oasisprotocol/nexus#84 and oasisprotocol/oasis-wallet-web#927
https://nexus.oasis.io/v1/consensus/accounts?limit=1
"available":"0","debonding":"0","escrow":"0"
single account API returns correct fields
https://nexus.oasis.io/v1/consensus/accounts/oasis1qz78ap0456g2rk7j6rmtvasc9v2kjhz2s58qgj90
"available":"21454060793","debonding":"0","debonding_delegations_balance":"0","delegations_balance":"103544825467","escrow":"0"
There was a problem hiding this comment.
I will leave TODOs in this case.
buberdds
commented
Jan 23, 2024
buberdds
commented
Jan 24, 2024
buberdds
force-pushed
the
mz/consensusDashboardAccountList
branch
6 times, most recently
from
d2c3637
to
a858a1c
Compare
buberdds
force-pushed
the
mz/consensusDashboardAccountList
branch
from
a858a1c
to
02667f8
Compare
lukaw3d
approved these changes
Feb 1, 2024
buberdds
force-pushed
the
mz/consensusDashboardAccountList
branch
from
02667f8
to
7677996
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.