Don't use misleading balance fields from RPC #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaw3d
changed the title
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
buberdds
approved these changes
Jul 13, 2022
buberdds
reviewed
Jul 13, 2022
| <div | ||
| class="c10" | ||
| > | ||
| 0.0000001 |
There was a problem hiding this comment.
Where this balance is defined ?
There was a problem hiding this comment.
lukaw3d
force-pushed
the
lw/rpc-balances
branch
2 times, most recently
from
8330d65
to
5e0de43
Compare
|
No idea why cypress CI runs forever on this PR 🤷 |
|
Pushing commit by commit 🤷 |
|
Update: something about grouping fields into |
Codecov Report
@@ Coverage Diff @@
## master #927 +/- ##
=======================================
Coverage 87.58% 87.59%
=======================================
Files 97 97
Lines 1619 1620 +1
Branches 353 353
=======================================
+ Hits 1418 1419 +1
Misses 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop using misleading
totalfield from parseRpcBalance, remove it, and group validator-specific fields. In the future we should convert some of these RPC calls to API calls and use correcttotalavailable + escrow (validator) + escrow_debonding (validator)available