Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace network and layer filters with SearchScope #447

Merged
merged 2 commits into from May 26, 2023
Merged

Replace network and layer filters with SearchScope #447

merged 2 commits into from May 26, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented May 25, 2023

Extracted from #438

@lukaw3d lukaw3d requested a review from csillag May 25, 2023 23:13
@github-actions
Copy link

github-actions bot commented May 25, 2023 •
edited

Deployed to Cloudflare Pages

Latest commit: 704f3c3e40892769f89268605825329e8fc09828
Status:✅ Deploy successful!
Preview URL: https://6d4336fb.oasis-explorer.pages.dev

csillag
csillag approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@csillag csillag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (since I wrote it initially.)
Let's hope it actually works without the reset of the pending changes.

@csillag csillag merged commit 2f4b1bc into master May 26, 2023
4 checks passed
@csillag csillag deleted the lw/search-scope branch May 26, 2023 01:46
@csillag csillag mentioned this pull request May 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csillag csillag csillag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukaw3d @csillag