Continue the work on cross-network / cross-paratime search #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
|
@donouwens says (on Slack):
So... finally we can get on with the technical review, yay! |
csillag
force-pushed
the
csillag/cross-chain-search-reloaded
branch
from
f90f59a
to
4796e7f
Compare
lukaw3d
force-pushed
the
csillag/cross-chain-search-reloaded
branch
3 times, most recently
from
d6dd2db
to
b0ee3e6
Compare
lukaw3d
reviewed
May 26, 2023
csillag
force-pushed
the
csillag/cross-chain-search-reloaded
branch
3 times, most recently
from
32a5af7
to
0dc37ae
Compare
csillag
force-pushed
the
csillag/cross-chain-search-reloaded
branch
from
5ebcba6
to
e1b4e8c
Compare
csillag
force-pushed
the
csillag/cross-chain-search-reloaded
branch
from
e1b4e8c
to
503f712
Compare
|
I separated the components for global search results and scoped search results. I think it's easier to read now. |
csillag
force-pushed
the
csillag/cross-chain-search-reloaded
branch
8 times, most recently
from
696ed38
to
f8ffed8
Compare
lukaw3d
reviewed
May 29, 2023
csillag
force-pushed
the
csillag/cross-chain-search-reloaded
branch
from
f8ffed8
to
8d7ae68
Compare
csillag
changed the title
lukaw3d
reviewed
Jun 5, 2023
lukaw3d
reviewed
Jun 5, 2023
csillag
force-pushed
the
csillag/cross-chain-search-reloaded
branch
3 times, most recently
from
7f97e16
to
a094f63
Compare
lukaw3d
reviewed
Jun 6, 2023
lukaw3d
approved these changes
Jun 6, 2023
csillag
force-pushed
the
csillag/cross-chain-search-reloaded
branch
6 times, most recently
from
ebc16b7
to
635302c
Compare
Don't list all blocks, txs, accounts separately; use a single list, with type information added.
csillag
force-pushed
the
csillag/cross-chain-search-reloaded
branch
from
c0252d9
to
f060f9c
Compare
Filtering has been moved up one layer, so it makes no sense to call this file Filtered anymore.
|
I have now cut this to multiple commits, and will merge as soon as the tests are finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the successor of #438; the remaining parts since #447 has been extracted and merged.