Improve handling of nameless ERC-20 tokens #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
|
Could we replace the '???' with 'n/a', please @csillag |
csillag
force-pushed
the
csillag/handle-nameless-tokens
branch
from
840ee69
to
4cfa0d0
Compare
|
OK, so now it looks like this: |
buberdds
approved these changes
Jun 14, 2023
csillag
force-pushed
the
csillag/handle-nameless-tokens
branch
from
4cfa0d0
to
12e7565
Compare
csillag
force-pushed
the
csillag/handle-nameless-tokens
branch
from
12e7565
to
89a7d47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some ERC-20 tokens which don't have a name or a ticker, because these are (strictly speaking) not mandatory parts of the contract specification. We still need to display something on the UI.
This can be tested with account 0x0df7C50f085345a12A2d06cE0D5519607b6E9B47 (Sapphire, Testnet.)
Before:
After: