Improve performance when displaying token balance list #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/optimize-token-balance-list
branch
3 times, most recently
from
2bc2980
to
cee9430
Compare
csillag
force-pushed
the
csillag/optimize-token-balance-list
branch
from
cee9430
to
a70fbf9
Compare
|
Tested with latest staging Nexus deployment, seems to work fine. (For testing, I had to change the API endpoints to staging, and enable Emerald.) |
csillag
force-pushed
the
csillag/optimize-token-balance-list
branch
4 times, most recently
from
d1b9bdb
to
7e52f9d
Compare
|
Now that the relevant Nexus changes have been merged, this PR has also been updated accordingly. |
lukaw3d
approved these changes
Aug 1, 2023
Make it so that it's easier to use dta from other sources.
(Instead of sending another request to look up the token data.)
csillag
force-pushed
the
csillag/optimize-token-balance-list
branch
from
7e52f9d
to
36d8bd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on oasisprotocol/nexus#492.This also depends on #761. (Since the Nexus PRs also depend on each other.)Please note that while this version is backward compatible with the currently deployed staging or production versions of nexus, the performance improvements will only be realized if the new version of nexus is deployed.