Improve performance when displaying event lists, using newly available data#761
Conversation
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/optimize-runtime-event-list
branch
2 times, most recently
from
8e05db0 to
61c179a
Compare
|
Tested with latest staging Nexus deployment, seems to work fine. (For testing, I had to change the API endpoints to staging, and enable Emerald.) |
| content: transfer.evm_log_details?.token_type ? ( | ||
| <EventBalance event={transfer} tickerAsLink={differentTokens} /> | ||
| ) : ( | ||
| <DelayedEventBalance event={transfer} tickerAsLink={differentTokens} /> |
There was a problem hiding this comment.
Can delayed versions of these components ever actually obtain more information, if backend JOIN couldn't?
Or is this so that we can deploy before API is updated, and later remove it?
There was a problem hiding this comment.
Yes, the intention behind the current code is that it should work optimally if the newly added data is present, and fall back gracefully to lower performance if it's not.
As far as I can understand, this data will always be there for transfers, so maybe we can remove the delayed codepath later, but then again, it's a bit vague what do we consider to be a transfer, so I am not enterely certain about that. (But I'll try to check with the Nexus devs.)
csillag
force-pushed
the
csillag/optimize-runtime-event-list
branch
from
61c179a to
07e48d0
Compare
|
Now that the relevant Nexus changes have been merged, this PR has also been updated accordingly. |
csillag
force-pushed
the
csillag/optimize-runtime-event-list
branch
from
079cdee to
802dc6b
Compare
Instead of looking up the referenced tokens, try to use the data available as part of the runtime event info.
csillag
force-pushed
the
csillag/optimize-runtime-event-list
branch
from
802dc6b to
33c5eff
Compare
2 participants
This depends on oasisprotocol/nexus#491.Please note that while this version is backward compatible with the currently deployed staging or production versions of nexus, the performance improvements will only be realized if the new version of nexus is deployed.