New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename oasis-indexer
to nexus
#467
Conversation
Command: find -not -path '*/.git/*' -not -path './cache/*' -type f | xargs sed -i -E 's!github.com/(oasisprotocol|oasislabs)/oasis-indexer!github.com/oasisprotocol/nexus!g'
07b3130
to
0e24212
Compare
… Docker repo name is excluded.
Ran: gofumpt -w . goimports -local github.com/oasisprotocol/nexus -w .
…local and CI scenarios)
0e24212
to
9267e93
Compare
oasis-indexer
to nexus
oasis-indexer
to nexus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks!
@@ -46,7 +46,7 @@ jobs: | |||
run: go install github.com/deepmap/oapi-codegen/cmd/oapi-codegen@v1.12 | |||
- name: Build Go | |||
run: | | |||
make oasis-indexer | |||
make nexus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(no-op) I'd prefer oasis-nexus
over nexus
since we refer to it as Oasis Nexus in the docs. It'd also be consistent with Oasis Explorer and how most of our services historically were prefixed with oasis-
. But since this rename is requested by marketing it's not up to us so I'll just lodge my objection here for posterity and we can leave as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually prefer nexus
here because it's more of a token/identifier, and in that role, we never use oasis-nexus
(with a hyphen); for consistency and simplicity, I like that we always have one or the other.
We mostly use "Oasis Nexus" in external docs when there is little external context and we want to additional qualify the name. We also use just "Nexus" in externally facing docs plenty of time.
Marketing directive.
Renames/changes:
oasis-indexer
path components are renamednexus
, including mount points and the name of the main binaryoasis-indexer
withnexus
, rather than being very selective and changing only some, e.g. keeping oasis-indexer in most places but renaming only the binary (a "requirement"). It will hopefully also reduce confusion for readers to mostly have a single name used consistently.Does NOT rename/change: