-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the random beacon suck less #3180
Conversation
5f073ab
to
a6a3422
Compare
Codecov Report
@@ Coverage Diff @@
## master #3180 +/- ##
==========================================
- Coverage 67.38% 66.80% -0.59%
==========================================
Files 390 391 +1
Lines 36687 38122 +1435
==========================================
+ Hits 24723 25468 +745
- Misses 8511 9000 +489
- Partials 3453 3654 +201
Continue to review full report at Codecov.
|
00d7fa0
to
ccec498
Compare
7e68e40
to
c89c478
Compare
34a1283
to
ce2e057
Compare
a8a0610
to
5eb6231
Compare
895d4d3
to
59a1542
Compare
d631aef
to
ddefca4
Compare
@@ -71,8 +72,9 @@ type Node struct { // nolint: maligned | |||
// Beacon contains information for this node's participation | |||
// in the random beacon protocol. | |||
// | |||
// NOTE: This is reserved for future use. | |||
Beacon cbor.RawMessage `json:"beacon,omitempty"` | |||
// TODO: This is optional for now, make mandatory once enough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make this required in master? And optional in the backported version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on how the transition will happen. We could save a bunch of backporting effort if the transition is just "Deploy the new code with the old backend enabled, then switch backends at a later date". If that is the option taken, then this needs to remain optional.
ddefca4
to
d2dbed4
Compare
While well intentioned, the 1 epoch wait after the halt epoch does not make sense with the new consensus driven timekeeping method, and will not work at all due to timekeeping services relying on consensus operations that get disabled via the halt process.
d2dbed4
to
ec069aa
Compare
* Unify the beacon and epochtime components under beacon * Add support for multiple beacon backends * Add the initial PVSS backend
ec069aa
to
fc3cc5f
Compare
(Blocked on Runtime upgrade E2E test should wait for old node expiration #3404)To be done later (file issues after merge):
I'm not the most thrilled by the performance from the PVSS scheme when used without pairing based crypto, but it has several nice properties: