Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CHANGELOG.md and use towncrier for automatic assembly #2496

Merged
merged 4 commits into from
Dec 23, 2019

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Dec 20, 2019

Closes #759.

@tjanez tjanez force-pushed the tjanez/add-changelog branch 3 times, most recently from b13a83a to 2d4f421 Compare December 20, 2019 13:41
@codecov
Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #2496 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2496      +/-   ##
==========================================
+ Coverage   67.06%   67.21%   +0.15%     
==========================================
  Files         324      324              
  Lines       29880    29880              
==========================================
+ Hits        20038    20085      +47     
+ Misses       7360     7322      -38     
+ Partials     2482     2473       -9
Impacted Files Coverage Δ
go/consensus/tendermint/roothash/roothash.go 63.67% <0%> (-6%) ⬇️
go/worker/txnscheduler/committee/node.go 70.3% <0%> (-2.63%) ⬇️
go/storage/metrics.go 74.13% <0%> (-2.59%) ⬇️
go/storage/client/client.go 71.37% <0%> (-1.09%) ⬇️
go/worker/merge/committee/node.go 74.63% <0%> (-0.25%) ⬇️
go/consensus/tendermint/tendermint.go 64.22% <0%> (+0.71%) ⬆️
go/worker/registration/worker.go 65.51% <0%> (+0.94%) ⬆️
go/runtime/transaction/transaction.go 78.04% <0%> (+1.21%) ⬆️
go/worker/common/committee/group.go 82.52% <0%> (+1.48%) ⬆️
go/worker/common/p2p/p2p.go 71.17% <0%> (+2.7%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d34a8...8fd3c0c. Read the comment docs.

@tjanez tjanez force-pushed the tjanez/add-changelog branch 2 times, most recently from 5b120c7 to 0acb530 Compare December 20, 2019 14:51
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

The lint on GitHub Actions seems to be failing though, seems like some issue with the remote branch not being fully fetched? Probably an explicit git fetch origin <BASE-BRANCH> is needed because the linter tries to inspect what changed from the base branch.

And then run:

```bash
towncrier build --version <NEXT-VERSION> --draft
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about when you want to do an actual release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would leave out the --draft argument and towncrier would stage the changes, i.e. remove the Change Log fragments and add a new section to the CHANGELOG.md.
After verifying that everything looks ok, you would just commit the changes.

I plan to create changelog Make target that would call towncrier underneath to make things even simpler.

pro-wh
pro-wh previously requested changes Dec 20, 2019
CHANGELOG.md Outdated

## 19.0 (2019-12-18)

- Initial release.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have this not say 19.0 (2019-12-18) is the initial release? it's not the initial release. if we don't want to go back and retroactively describe what changed between a9a532e and 19.0, it's less confusing not to have this section at all

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this is not ideal. I would still like to have this section so that readers will know what the Change Log section for the next release, i.e. 19.1, refers to.

I've changed the contents to actually describe a process change, i.e. that the project started using a new versioning and release process and adopted a CalVer (calendar versioning) scheme. The latter also explains why this release has version 19.0 as opposed to 1.0 or similar.

Please, take another look.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the changes

@tjanez tjanez force-pushed the tjanez/add-changelog branch 2 times, most recently from f1da340 to c8b606a Compare December 20, 2019 22:14
@tjanez
Copy link
Member Author

tjanez commented Dec 20, 2019

The lint on GitHub Actions seems to be failing though, seems like some issue with the remote branch not being fully fetched? Probably an explicit git fetch origin <BASE-BRANCH> is needed because the linter tries to inspect what changed from the base branch.

Yes, indeed the GitHub Checkout action only fetches the pull request branch by default. Added a command that manually fetches the master branch.

@tjanez tjanez dismissed pro-wh’s stale review December 23, 2019 10:00

Warren ACKed the PR via Slack

@tjanez tjanez merged commit 8d63176 into master Dec 23, 2019
@tjanez tjanez deleted the tjanez/add-changelog branch December 23, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically generate the changelog
3 participants