go/consensus: use typed attributes in all services

[ptrus]

No description provided.

[codecov]

Codecov Report

Merging #4465 (c3bda78) into master (b4de534) will decrease coverage by 0.08%.
The diff coverage is 79.43%.

❗ Current head c3bda78 differs from pull request most recent head ba0023b. Consider uploading reports for the commit ba0023b to get more accurate results

@@            Coverage Diff             @@
##           master    #4465      +/-   ##
==========================================
- Coverage   68.87%   68.78%   -0.09%     
==========================================
  Files         421      423       +2     
  Lines       47174    47225      +51     
==========================================
- Hits        32489    32485       -4     
- Misses      10697    10744      +47     
- Partials     3988     3996       +8     

Impacted Files	Coverage Δ
go/consensus/tendermint/roothash/roothash.go	67.16% <52.77%> (-0.60%)	⬇️
go/consensus/tendermint/scheduler/scheduler.go	58.02% <60.00%> (ø)
go/consensus/tendermint/registry/registry.go	66.18% <65.00%> (-2.42%)	⬇️
go/consensus/tendermint/apps/beacon/beacon.go	73.77% <75.00%> (ø)
go/consensus/tendermint/keymanager/keymanager.go	78.84% <75.00%> (ø)
go/consensus/tendermint/beacon/beacon.go	72.24% <80.00%> (ø)
go/beacon/api/api.go	55.55% <100.00%> (+5.55%)	⬆️
go/consensus/tendermint/api/api.go	84.46% <100.00%> (+0.30%)	⬆️
go/consensus/tendermint/api/context.go	88.63% <100.00%> (ø)
go/consensus/tendermint/apps/keymanager/genesis.go	59.61% <100.00%> (+1.61%)	⬆️
... and 52 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39e5f61...ba0023b. Read the comment docs.

[kostko]

Since we're here, Tendermint 0.35 requires all events to be actual strings and doesn't support binary data anymore (so values would need to be Base64-encoded). It also requires no dashes in attribute keys. Maybe we should make the change now to avoid breaking changes later (also see #4427)? cc @abukosek

[ptrus]

Maybe we should make the change now to avoid breaking changes later

Makes sense yes