Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add observer nodes automatically to ACL #5606

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

jberci
Copy link
Contributor

@jberci jberci commented Mar 21, 2024

No description provided.

Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit c630125
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/660194ce916643000848fd3b

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 61.36364% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 65.82%. Comparing base (d6aa083) to head (c630125).
Report is 1 commits behind head on master.

Files Patch % Lines
go/worker/keymanager/watcher.go 61.36% 11 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5606      +/-   ##
==========================================
+ Coverage   65.40%   65.82%   +0.42%     
==========================================
  Files         588      588              
  Lines       60178    60210      +32     
==========================================
+ Hits        39362    39636     +274     
+ Misses      16168    15911     -257     
- Partials     4648     4663      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jberci jberci marked this pull request as ready for review March 22, 2024 11:36
go/worker/keymanager/watcher.go Outdated Show resolved Hide resolved
go/worker/keymanager/watcher.go Outdated Show resolved Hide resolved
go/worker/keymanager/watcher.go Outdated Show resolved Hide resolved
go/worker/keymanager/watcher.go Outdated Show resolved Hide resolved
go/worker/keymanager/watcher.go Show resolved Hide resolved
go/worker/keymanager/watcher.go Outdated Show resolved Hide resolved
go/worker/keymanager/watcher.go Outdated Show resolved Hide resolved
@jberci jberci merged commit e39ffaf into master Mar 25, 2024
6 of 7 checks passed
@jberci jberci deleted the jberci/feature/observers branch March 25, 2024 20:16
go/worker/keymanager/watcher.go Show resolved Hide resolved
go/worker/keymanager/watcher.go Show resolved Hide resolved
go/worker/keymanager/watcher.go Show resolved Hide resolved
go/worker/keymanager/watcher.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants