Support detached ROFL components #5707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
kostko
force-pushed
the
kostko/feature/rofl-detached
branch
5 times, most recently
from
474120f
to
0eda644
Compare
kostko
requested review from
peterjgilbert,
pro-wh,
ptrus and
peternose
as code owners
kostko
force-pushed
the
kostko/feature/rofl-detached
branch
from
0eda644
to
bb97157
Compare
peternose
approved these changes
May 31, 2024
kostko
force-pushed
the
kostko/feature/rofl-detached
branch
2 times, most recently
from
27366da
to
a9d7132
Compare
peternose
approved these changes
Jun 3, 2024
Previously each bundle that contained one or more ROFL components also needed to contain the exact version of the RONL component it was attaching to. This is somewhat awkward to use when we assume a more decentralized development and deployment of ROFL applications. This commit adds support for detached ROFL components where the bundle only contains the ROFL and oasis-node then automatically gets the appropriate RONL component from another bundle.
kostko
force-pushed
the
kostko/feature/rofl-detached
branch
from
a9d7132
to
ef6ccb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously each bundle that contained one or more ROFL components also needed to contain the exact version of the RONL component it was attaching to.
This is somewhat awkward to use so this adds support for detached ROFL components where the bundle only contains the ROFL and oasis-node then automatically gets the appropriate RONL component from another bundle.