Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-sdk/modules/evm: Add subcall precompile #1412

Merged
merged 2 commits into from Aug 1, 2023

Conversation

kostko
Copy link
Member

@kostko kostko commented Jul 12, 2023

Based on #1411

@kostko kostko force-pushed the kostko/feature/evm-precompile-staking branch 2 times, most recently from 2d418e3 to 85e3e07 Compare July 12, 2023 19:38
@kostko kostko force-pushed the kostko/feature/current-store-subcalls branch from 444f5ae to 39cc9b2 Compare July 14, 2023 06:19
Base automatically changed from kostko/feature/current-store-subcalls to main July 14, 2023 06:50
@kostko kostko force-pushed the kostko/feature/evm-precompile-staking branch from 85e3e07 to c489e1d Compare July 14, 2023 06:51
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #1412 (f812421) into main (9104b4b) will decrease coverage by 0.87%.
The diff coverage is 70.55%.

@@            Coverage Diff             @@
##             main    #1412      +/-   ##
==========================================
- Coverage   56.83%   55.97%   -0.87%     
==========================================
  Files         132      134       +2     
  Lines        9324     9512     +188     
==========================================
+ Hits         5299     5324      +25     
- Misses       3983     4146     +163     
  Partials       42       42              
Files Changed Coverage Δ
runtime-sdk/modules/evm/src/precompile/testing.rs 73.33% <0.00%> (-2.53%) ⬇️
runtime-sdk/modules/evm/src/raw_tx.rs 86.23% <ø> (ø)
runtime-sdk/src/context.rs 69.14% <33.33%> (-2.93%) ⬇️
runtime-sdk/src/dispatcher.rs 16.71% <50.00%> (+2.91%) ⬆️
runtime-sdk/modules/contracts/src/results.rs 60.00% <66.66%> (+0.22%) ⬆️
runtime-sdk/modules/evm/src/backend.rs 70.33% <70.46%> (+9.83%) ⬆️
runtime-sdk/modules/evm/src/precompile/subcall.rs 70.83% <70.83%> (ø)
runtime-sdk/modules/evm/src/mock.rs 89.47% <89.47%> (ø)
runtime-sdk/src/testing/mock.rs 85.45% <90.90%> (+1.36%) ⬆️
client-sdk/go/types/address.go 58.33% <100.00%> (+1.01%) ⬆️
... and 5 more

... and 3 files with indirect coverage changes

@kostko kostko force-pushed the kostko/feature/evm-precompile-staking branch from c489e1d to 9829a82 Compare July 14, 2023 08:18
@kostko kostko force-pushed the kostko/feature/evm-precompile-staking branch 6 times, most recently from 23ba6c5 to b6797d4 Compare July 17, 2023 16:22
@kostko kostko force-pushed the kostko/feature/evm-precompile-staking branch 3 times, most recently from 83aed97 to 1f27002 Compare July 18, 2023 12:28
runtime-sdk/modules/evm/src/backend.rs Outdated Show resolved Hide resolved
runtime-sdk/modules/evm/src/backend.rs Outdated Show resolved Hide resolved
@kostko kostko force-pushed the kostko/feature/evm-precompile-staking branch from 1f27002 to dd6c268 Compare July 23, 2023 16:08
@kostko kostko marked this pull request as ready for review July 23, 2023 16:37
@kostko kostko requested a review from pro-wh as a code owner July 23, 2023 16:37
@kostko kostko force-pushed the kostko/feature/evm-precompile-staking branch from dd6c268 to 90976c5 Compare July 27, 2023 12:01
Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've scrolled through to see how this works, looking good. lots of this will also help in the future to see how native tokens are moving in the evm

client-sdk/go/modules/evm/address.go Outdated Show resolved Hide resolved
client-sdk/go/modules/evm/address_test.go Outdated Show resolved Hide resolved
runtime-sdk/modules/evm/src/raw_tx.rs Show resolved Hide resolved
runtime-sdk/modules/contracts/src/results.rs Show resolved Hide resolved
runtime-sdk/modules/evm/src/precompile/mod.rs Show resolved Hide resolved
runtime-sdk/modules/evm/src/precompile/subcall.rs Outdated Show resolved Hide resolved
runtime-sdk/modules/evm/src/precompile/subcall.rs Outdated Show resolved Hide resolved
}
}

/// Test contract code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need to amend this comment with To generate the contract bytecode below, use https://remix.ethereum.org/...

client-sdk/go/modules/evm/address.go Outdated Show resolved Hide resolved
runtime-sdk/modules/evm/src/backend.rs Outdated Show resolved Hide resolved
runtime-sdk/modules/evm/src/backend.rs Show resolved Hide resolved
runtime-sdk/modules/evm/src/backend.rs Outdated Show resolved Hide resolved
runtime-sdk/modules/evm/src/backend.rs Show resolved Hide resolved
runtime-sdk/modules/evm/src/mock.rs Show resolved Hide resolved
@kostko kostko force-pushed the kostko/feature/evm-precompile-staking branch 2 times, most recently from beda229 to 828a417 Compare July 28, 2023 10:18
@kostko kostko force-pushed the kostko/feature/evm-precompile-staking branch from 828a417 to 170ba4e Compare July 28, 2023 19:46
Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

design sounds good

@kostko kostko force-pushed the kostko/feature/evm-precompile-staking branch from 170ba4e to f812421 Compare August 1, 2023 18:21
@kostko kostko enabled auto-merge August 1, 2023 18:22
@kostko kostko merged commit 86a22a2 into main Aug 1, 2023
26 of 27 checks passed
@kostko kostko deleted the kostko/feature/evm-precompile-staking branch August 1, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants