Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evm: add c10l EVM e2e test #991

Merged
merged 13 commits into from
Jul 1, 2022
Merged

evm: add c10l EVM e2e test #991

merged 13 commits into from
Jul 1, 2022

Conversation

nhynes
Copy link
Contributor

@nhynes nhynes commented Jun 14, 2022 •
edited
Loading

No description provided.

@nhynes nhynes changed the base branch from main to sapphire/signed-queries June 14, 2022 06:54
@codecov
Copy link

codecov bot commented Jun 14, 2022 •
edited
Loading

Codecov Report

Merging #991 (ce251d4) into main (015d857) will decrease coverage by 0.42%.
The diff coverage is 83.89%.

@@            Coverage Diff             @@
##             main     #991      +/-   ##
==========================================
- Coverage   68.37%   67.94%   -0.43%     
==========================================
  Files         126      128       +2     
  Lines       10677    10889     +212     
==========================================
+ Hits         7300     7399      +99     
- Misses       3352     3458     +106     
- Partials       25       32       +7
Impacted Files Coverage Δ
runtime-sdk/modules/evm/src/lib.rs 48.92% <60.00%> (ø)
client-sdk/go/modules/evm/signed_calls.go 81.44% <81.44%> (ø)
client-sdk/go/testing/testing.go 95.23% <90.47%> (-4.77%) ⬇️
runtime-sdk/modules/evm/src/signed_query.rs 96.27% <92.30%> (+0.14%) ⬆️
runtime-sdk/modules/evm/src/raw_tx.rs 90.00% <0.00%> (-0.59%) ⬇️
client-sdk/go/modules/evm/evm.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 015d857...ce251d4. Read the comment docs.

@nhynes nhynes changed the base branch from sapphire/signed-queries to main June 14, 2022 07:38
kostko
kostko reviewed Jun 14, 2022
View reviewed changes
runtime-sdk/modules/evm/src/lib.rs Outdated Show resolved Hide resolved
runtime-sdk/modules/evm/src/lib.rs Outdated Show resolved Hide resolved
@nhynes nhynes force-pushed the sapphire/e2e-test branch 11 times, most recently from d70c147 to 62b5d1c Compare June 16, 2022 10:19
@nhynes nhynes force-pushed the sapphire/e2e-test branch 2 times, most recently from d5eca7a to 4ef6df5 Compare June 28, 2022 17:00
@nhynes nhynes changed the title Add c10l EVM e2e test evm: add c10l EVM e2e test Jun 28, 2022
@nhynes nhynes marked this pull request as ready for review June 28, 2022 17:01
@nhynes nhynes requested review from pro-wh and ptrus as code owners June 28, 2022 17:01
@nhynes nhynes force-pushed the sapphire/e2e-test branch 7 times, most recently from 133d973 to 5d06ad0 Compare June 29, 2022 07:54
@nhynes nhynes requested a review from kostko June 29, 2022 12:33
nhynes
nhynes commented Jun 29, 2022
View reviewed changes
client-sdk/go/modules/evm/signed_calls.go
@@ -0,0 +1,146 @@
package evm
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be moved into the sapphire-paratime repo now that it's public

kostko
kostko reviewed Jun 30, 2022
View reviewed changes
tests/runtimes/simple-evm/src/lib.rs Outdated Show resolved Hide resolved
client-sdk/go/testing/testing.go Outdated Show resolved Hide resolved
client-sdk/go/testing/testing.go Outdated Show resolved Hide resolved
runtime-sdk/modules/evm/src/signed_query.rs Show resolved Hide resolved
@kostko kostko mentioned this pull request Jun 30, 2022
Merged
@nhynes nhynes requested a review from kostko June 30, 2022 18:07
@nhynes nhynes merged commit 253d8cf into main Jul 1, 2022
@nhynes nhynes deleted the sapphire/e2e-test branch July 1, 2022 04:12
tjanez pushed a commit to oasisprotocol/cli that referenced this pull request Sep 20, 2022
@nhynes
evm: add c10l EVM e2e test (oasisprotocol/oasis-sdk#991)
f70c8e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matevz matevz matevz left review comments

@kostko kostko kostko approved these changes

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@ptrus ptrus Awaiting requested review from ptrus ptrus is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nhynes @matevz @kostko