Add Sapphire on testnet #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaw3d
force-pushed
the
lw/sapphire-testnet
branch
2 times, most recently
from
01ea0e9
to
c40040a
Compare
lukaw3d
requested review from
pro-wh,
peterjgilbert,
kostko and
tjanez
as code owners
lukaw3d
force-pushed
the
lw/sapphire-testnet
branch
2 times, most recently
from
fa80afa
to
c57582d
Compare
lukaw3d
force-pushed
the
lw/sapphire-testnet
branch
from
c57582d
to
2d22887
Compare
buberdds
approved these changes
Aug 8, 2022
| @@ -808,7 +808,7 @@ class APIService { | |||
| let u8Hash = await oasis.hash.hash(oasis.misc.toCBOR(txWrapper.unverifiedTransaction)) | |||
| let hash = oasis.misc.toHex(u8Hash) | |||
| let config = getRuntimeConfig(params.runtimeId) | |||
| if (hash && config.accountType === RUNTIME_ACCOUNT_TYPE.EVM) { | |||
There was a problem hiding this comment.
What was wrong with this approach?
Also does that PR need to address another use cases like
let isEmerald = runtimeConfig.accountType === RUNTIME_ACCOUNT_TYPE.EVM where now we have multiple EVMc paratimes?
There was a problem hiding this comment.
Do you mean with if (hash && config.accountType === RUNTIME_ACCOUNT_TYPE.EVM && config.runtimeName === "Emerald") { approach? There's no difference
I think all other conditions are okay. (but isEmerald is a bad name - and there's already isEvm too :/ )
This was referenced Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.