Misc improvements #282
Misc improvements #282
Conversation
lukaw3d
requested review from
pro-wh,
peterjgilbert,
kostko and
tjanez
as code owners
| @@ -755,7 +755,9 @@ class APIService { | |||
| const tw = oasis.staking.allowWrapper() | |||
| params.method = TRANSACTION_TYPE.StakingAllow | |||
| params.toAddress = oasis.staking.addressToBech32(await oasis.staking.addressFromRuntimeID(oasis.misc.fromHex(params.runtimeId))) | |||
| let result = await this.submitTxBody(params, tw,true,(data)=>this.depositToParatimeAccount(params,resolve,reject,data)).catch(err=>err) | |||
| let result = await this.submitTxBody(params, tw, true, (data) => { | |||
There was a problem hiding this comment.
no need to use curly braces here
There was a problem hiding this comment.
My preference is to have a curly for multiline
There was a problem hiding this comment.
also nice to use braces for statements (even single statements imo) and no braces for expressions
| "oasis-xu-frame.html" | ||
| ] | ||
| "web_accessible_resources": ["oasis-xu-frame.html"], | ||
| "externally_connectable": { "ids": [] } |
There was a problem hiding this comment.
What's a benefit of adding this entry when empty ids array is the same as unspecified externally_connectable manifest key (as long as this theory is true)?
There was a problem hiding this comment.
Empty externally_connectable would do the same. But I think this is easier to understand intuitively, without looking at documentation :D
and I can't add a comment
| @@ -755,7 +755,9 @@ class APIService { | |||
| const tw = oasis.staking.allowWrapper() | |||
| params.method = TRANSACTION_TYPE.StakingAllow | |||
| params.toAddress = oasis.staking.addressToBech32(await oasis.staking.addressFromRuntimeID(oasis.misc.fromHex(params.runtimeId))) | |||
| let result = await this.submitTxBody(params, tw,true,(data)=>this.depositToParatimeAccount(params,resolve,reject,data)).catch(err=>err) | |||
| let result = await this.submitTxBody(params, tw, true, (data) => { | |||
There was a problem hiding this comment.
also nice to use braces for statements (even single statements imo) and no braces for expressions
Retry often fails with "invalid nonce"
Fixes "invalid nonce" part of #153