Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly disable externally_connectable in manifest #1109

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Oct 26, 2022

@lukaw3d lukaw3d requested a review from buberdds October 26, 2022 16:28
@github-actions
Copy link

github-actions bot commented Oct 26, 2022

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.0s
✅ JSON eslint-plugin-jsonc 1 0 0 0.97s
✅ JSON jsonlint 1 0 0.21s
✅ JSON prettier 1 0 0 0.45s
✅ JSON v8r 1 0 1.75s
✅ REPOSITORY checkov yes no 11.91s
✅ REPOSITORY git_diff yes no 0.0s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #1109 (9b0b403) into master (2ef70ef) will decrease coverage by 5.08%.
The diff coverage is 64.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1109      +/-   ##
==========================================
- Coverage   88.77%   83.68%   -5.09%     
==========================================
  Files         103      121      +18     
  Lines        1781     2249     +468     
  Branches      411      539     +128     
==========================================
+ Hits         1581     1882     +301     
- Misses        200      367     +167     
Flag Coverage Δ
cypress 51.80% <23.04%> (-8.84%) ⬇️
jest 76.88% <64.72%> (-1.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/ErrorFormatter/index.tsx 100.00% <ø> (ø)
src/app/pages/AccountPage/index.tsx 95.16% <ø> (ø)
src/app/state/transaction/index.ts 82.85% <0.00%> (-2.44%) ⬇️
src/store/reducers.ts 100.00% <ø> (ø)
src/store/sagas.ts 100.00% <ø> (ø)
src/styles/theme/ThemeProvider.tsx 100.00% <ø> (ø)
src/types/errors.ts 50.00% <ø> (ø)
src/app/pages/ParaTimesPage/index.tsx 6.45% <6.45%> (ø)
src/app/state/paratimes/index.ts 7.14% <7.14%> (ø)
src/app/lib/eth-helpers.ts 30.76% <30.76%> (ø)
... and 27 more

@lukaw3d lukaw3d merged commit ea5c74c into master Oct 26, 2022
@lukaw3d lukaw3d deleted the lw/externally-connectable branch October 26, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants