Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Book #1635

Merged
merged 11 commits into from Sep 11, 2023
Merged

Address Book #1635

merged 11 commits into from Sep 11, 2023

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Sep 6, 2023

The first part of Address Book feature. I will add tests in a next PR (or after the first round of review) . In many places I am not following mockups strictly and I am using existing Grommet components etc.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2d08132
Status: ✅  Deploy successful!
Preview URL: https://a4be75fe.oasis-wallet.pages.dev
Branch Preview URL: https://mz-addr.oasis-wallet.pages.dev

View logs

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 22 0 0.14s
✅ JSON eslint-plugin-jsonc 1 0 0 1.0s
✅ JSON jsonlint 1 0 0.51s
✅ JSON npm-package-json-lint yes no 1.63s
✅ JSON prettier 1 0 0 0.52s
✅ JSON v8r 1 0 2.0s
✅ REPOSITORY checkov yes no 38.94s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 15.87s
✅ REPOSITORY trivy-sbom yes no 2.29s
✅ REPOSITORY trufflehog yes no 151.19s
✅ TSX eslint 11 0 0 6.93s
✅ TYPESCRIPT eslint 9 0 0 6.33s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #1635 (2d08132) into master (f11176f) will decrease coverage by 1.46%.
Report is 1 commits behind head on master.
The diff coverage is 47.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1635      +/-   ##
==========================================
- Coverage   82.67%   81.21%   -1.46%     
==========================================
  Files         163      171       +8     
  Lines        4180     4345     +165     
  Branches      745      777      +32     
==========================================
+ Hits         3456     3529      +73     
- Misses        724      816      +92     
Flag Coverage Δ
cypress 49.64% <16.98%> (-1.23%) ⬇️
jest 76.44% <47.30%> (-1.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...nts/Toolbar/Features/Account/ImportableAccount.tsx 100.00% <ø> (ø)
...nts/Toolbar/Features/Account/ManageableAccount.tsx 68.96% <ø> (ø)
src/app/state/persist/index.ts 41.17% <ø> (ø)
src/app/state/persist/saga.ts 34.93% <ø> (ø)
...nents/Toolbar/Features/Contacts/ContactAccount.tsx 36.11% <36.11%> (ø)
...s/Toolbar/Features/Contacts/ContactAccountForm.tsx 37.14% <37.14%> (ø)
src/app/state/contacts/index.ts 45.45% <45.45%> (ø)
...omponents/Toolbar/Features/Contacts/AddContact.tsx 46.15% <46.15%> (ø)
...app/components/Toolbar/Features/Contacts/index.tsx 46.42% <46.42%> (ø)
...ges/AccountPage/Features/SendTransaction/index.tsx 91.30% <50.00%> (-3.94%) ⬇️
... and 7 more

... and 2 files with indirect coverage changes

src/app/components/Toolbar/Features/Account/Account.tsx Outdated Show resolved Hide resolved
src/app/components/Toolbar/Features/Contacts/index.tsx Outdated Show resolved Hide resolved
src/app/state/contacts/selectors.ts Outdated Show resolved Hide resolved
src/app/state/contacts/types.ts Outdated Show resolved Hide resolved
src/locales/en/translation.json Outdated Show resolved Hide resolved
@buberdds buberdds force-pushed the mz/addr branch 5 times, most recently from 7814ac8 to 45be84f Compare September 11, 2023 10:15
@buberdds buberdds merged commit ac0ad1a into master Sep 11, 2023
10 of 12 checks passed
@buberdds buberdds deleted the mz/addr branch September 11, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants