Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Contacts available only when profile exists #1668

Merged
merged 1 commit into from Sep 15, 2023

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Sep 15, 2023

Option 3 from Slack thread:

What we want to do with features like Contacts when user is not using persisted state (profile):

  • doesn’t matter we show it always
  • hide Contacts tab
  • show Contacts tab with a different empty state and without Add Contact button
  • store Contacts in persisted store and under another localStorage key. Like theme where it is stored under selectedTheme key and oasis_wallet_persist_v1 (state)

Related to #1635

@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 15, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3bfcb95
Status: ✅  Deploy successful!
Preview URL: https://e87cb941.oasis-wallet.pages.dev
Branch Preview URL: https://mz-contactsavailable.oasis-wallet.pages.dev

View logs

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #1668 (58763de) into master (17ae7cb) will increase coverage by 0.03%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1668      +/-   ##
==========================================
+ Coverage   82.65%   82.69%   +0.03%     
==========================================
  Files         172      172              
  Lines        4365     4375      +10     
  Branches      780      781       +1     
==========================================
+ Hits         3608     3618      +10     
  Misses        757      757              
Flag Coverage Δ
cypress 49.40% <16.66%> (-0.14%) ⬇️
jest 77.96% <75.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...mponents/Toolbar/Features/SettingsButton/index.tsx 89.18% <0.00%> (-2.48%) ⬇️
src/styles/theme/ThemeProvider.tsx 100.00% <ø> (ø)
...app/components/Toolbar/Features/Contacts/index.tsx 91.89% <80.00%> (-8.11%) ⬇️

... and 5 files with indirect coverage changes

@buberdds buberdds merged commit 045998e into master Sep 15, 2023
11 of 12 checks passed
@buberdds buberdds deleted the mz/contactsAvailable branch September 15, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants