Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show AddEscrowForm on your accounts #918

Merged
merged 4 commits into from
Jul 8, 2022
Merged

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Jul 8, 2022

Fixes #917

Before After
before after

@lukaw3d lukaw3d requested review from buberdds and tjanez July 8, 2022 00:24
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 7 0 0.02s
✅ GIT git_diff yes no 0.01s
✅ TSX eslint 6 0 0 5.23s
✅ TYPESCRIPT eslint 1 0 0 4.26s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #918 (e46f690) into master (6bf5199) will decrease coverage by 0.01%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #918      +/-   ##
==========================================
- Coverage   87.25%   87.23%   -0.02%     
==========================================
  Files          98       99       +1     
  Lines        1624     1622       -2     
  Branches      350      350              
==========================================
- Hits         1417     1415       -2     
  Misses        207      207              
Flag Coverage Δ
cypress 57.82% <45.45%> (+<0.01%) ⬆️
jest 73.99% <81.81%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/AddEscrowForm/index.tsx 92.30% <0.00%> (ø)
src/app/components/Sidebar/index.tsx 88.31% <100.00%> (ø)
...ages/AccountPage/Features/AccountDetails/index.tsx 100.00% <100.00%> (ø)
...ages/StakingPage/Features/DelegationList/index.tsx 83.33% <100.00%> (-0.46%) ⬇️
...akingPage/Features/ValidatorList/ValidatorItem.tsx 85.71% <100.00%> (ø)
...pages/StakingPage/Features/ValidatorList/index.tsx 68.57% <100.00%> (ø)
src/app/state/selectIsAddressInWallet.ts 100.00% <100.00%> (ø)

@lukaw3d lukaw3d merged commit da8d0f7 into master Jul 8, 2022
@lukaw3d lukaw3d deleted the lw/stake-your-acc branch July 8, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Staking button is shown on not-your-account
2 participants