ParaTimes: deposit and withdraw #969

buberdds · 2022-08-12T14:16:34Z

PR adds

deposit/withdraw
missing UI pieces

Next PRs will cover:
#978 unit tests, lock view for a 'foreign' account

Collapsible advance section

Extended confirmation view

Failed Transaction view

src/app/lib/helpers.ts

src/app/lib/transaction.ts

src/app/state/account/types.ts

src/app/state/transaction/saga.ts

src/app/state/paratimes/saga.ts

src/app/state/transaction/saga.ts

src/app/lib/transaction.ts

src/app/state/transaction/saga.ts

src/config.ts

src/app/lib/transaction.ts

buberdds · 2022-08-25T16:12:50Z

I will push more UI changes here

src/app/lib/transaction.ts

src/app/pages/ParaTimesPage/index.tsx

src/app/state/transaction/saga.ts

src/app/pages/ParaTimesPage/TransactionConfirmation/index.tsx

src/app/pages/ParaTimesPage/TransactionAmount/FeesSection.tsx

src/app/state/account/selectors.ts

src/app/pages/ParaTimesPage/TransactionAmount/FeesSection.tsx

src/app/pages/ParaTimesPage/index.tsx

src/app/pages/ParaTimesPage/TransactionAmount/index.tsx

src/app/state/transaction/saga.ts

src/app/state/account/saga.test.ts

src/app/components/MobileFooterNavigation/__tests__/index.test.tsx

src/app/pages/ParaTimesPage/TransactionConfirmation/index.tsx

src/app/pages/ParaTimesPage/TransactionAmount/index.tsx

src/app/pages/ParaTimesPage/TransactionConfirmation/index.tsx

src/app/state/transaction/saga.test.ts

src/app/pages/ParaTimesPage/TransactionAmount/index.tsx

src/app/state/transaction/saga.ts

src/app/pages/ParaTimesPage/TransactionAmount/index.tsx

lukaw3d · 2022-09-08T01:18:02Z

src/app/pages/ParaTimesPage/TransactionAmount/index.tsx

                  label="MAX"
-                  onClick={() => setTransactionForm({ ...transactionForm, amount: formatter(balance) })}
+                  onClick={() =>


MAX doesn't work with fees.

E.g. withdrawing MAX from cipher (after removing setAllowance) fails with Unknown gRPC error: withdraw: insufficient runtime balance

I will address this one in a new PR.

src/app/pages/ParaTimesPage/index.tsx

src/app/pages/ParaTimesPage/TransactionAmount/index.tsx

lukaw3d · 2022-09-09T01:35:27Z

src/app/pages/ParaTimesPage/TransactionRecipient/__tests__/__snapshots__/index.test.tsx.snap

+  Please enter the address of the withdrawing wallet on the 
+  <strong>
+    Emerald
+  </strong>
+   (EVMc) ParaTime and then click "Next"


Text is misleading

When withdrawing from Emerald user should enter withdrawing private key and receiving address

When withdrawing from Cipher user enters receiving address

…posit

buberdds force-pushed the buberdds/wizard-deposit branch from bfcd23d to 3c26990 Compare August 12, 2022 14:17

buberdds requested a review from lukaw3d August 12, 2022 14:19

lukaw3d reviewed Aug 12, 2022

View reviewed changes

buberdds changed the title ~~ParaTime deposit~~ ParaTimes: deposit Aug 24, 2022

pro-wh reviewed Aug 24, 2022

View reviewed changes

src/app/lib/transaction.ts Show resolved Hide resolved

pro-wh reviewed Aug 24, 2022

View reviewed changes

src/app/lib/transaction.ts Outdated Show resolved Hide resolved

pro-wh reviewed Aug 24, 2022

View reviewed changes

src/app/lib/transaction.ts Outdated Show resolved Hide resolved

pro-wh reviewed Aug 24, 2022

View reviewed changes

src/app/lib/transaction.ts Outdated Show resolved Hide resolved

pro-wh reviewed Aug 24, 2022

View reviewed changes

src/app/state/transaction/saga.ts Outdated Show resolved Hide resolved

pro-wh reviewed Aug 24, 2022

View reviewed changes

src/config.ts Show resolved Hide resolved

pro-wh reviewed Aug 24, 2022

View reviewed changes

src/app/lib/transaction.ts Outdated Show resolved Hide resolved

buberdds changed the title ~~ParaTimes: deposit~~ ParaTimes: deposit and withdraw Aug 25, 2022

buberdds force-pushed the buberdds/wizard-deposit branch 3 times, most recently from c4dfb89 to fe0feca Compare August 30, 2022 09:07