Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI for "ParaTime wizard" #962

Merged
merged 1 commit into from
Aug 12, 2022
Merged

UI for "ParaTime wizard" #962

merged 1 commit into from
Aug 12, 2022

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Aug 9, 2022 •
edited
Loading

Next PRs will cover:

  • deposit to/from Cipher/Emerald/Sapphire ParaTime
  • withdraw EMVc withdraws need an extra step with recipient address.
  • allow access route only when wallet is 'open'
  • refresh account after successful action. We probably don't want to use current loader (with full page overflow)
  • add collapsible advance section with fees
  • transaction failure message / make success/error status more prominent in the last step
  • add more warnings (old extension modals) and additional ledger info
  • fix ETH value with comma not parsed correctly
  • CR:I think this should be BigInt(amount) > BigInt(value), and no need for EVM specific variant
  • unit tests
    Screenshot 2022-08-25 at 18 01 58
    Screenshot 2022-08-25 at 18 02 12
    Screenshot 2022-08-25 at 18 08 25
    Screenshot 2022-08-25 at 18 08 40
    Screenshot 2022-08-25 at 18 09 07
    Screenshot 2022-08-25 at 18 10 10

@buberdds buberdds requested a review from lukaw3d August 9, 2022 15:08
lukaw3d
lukaw3d reviewed Aug 10, 2022
View reviewed changes
src/app/lib/helpers.ts Outdated Show resolved Hide resolved
src/app/pages/ParaTimesPage/ParaTimeFormFooter/index.tsx Show resolved Hide resolved
src/app/lib/helpers.ts Show resolved Hide resolved
src/app/pages/ParaTimesPage/TransactionAmount/index.tsx Outdated Show resolved Hide resolved
src/app/pages/ParaTimesPage/TransactionRecipient/index.tsx Outdated Show resolved Hide resolved
src/app/state/paratimes/saga.ts Outdated Show resolved Hide resolved
src/app/state/paratimes/saga.ts Outdated Show resolved Hide resolved
src/app/state/paratimes/saga.ts Outdated Show resolved Hide resolved
src/app/state/paratimes/saga.ts Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
@buberdds buberdds force-pushed the buberdds/wizard branch 4 times, most recently from 6ca120f to b5ad7a2 Compare August 10, 2022 17:28
@buberdds buberdds requested a review from lukaw3d August 11, 2022 20:53
@buberdds buberdds merged commit b2eb2af into oasisprotocol:paratimes Aug 12, 2022
@lukaw3d lukaw3d mentioned this pull request Sep 1, 2022
Merged
@buberdds buberdds mentioned this pull request Oct 25, 2022
Merged
buberdds added a commit to buberdds/oasis-wallet-web that referenced this pull request Oct 25, 2022
@buberdds
Merge pull request oasisprotocol#962 from buberdds/buberdds/wizard
ab85620
lukaw3d added a commit that referenced this pull request Oct 25, 2022
@lukaw3d
Merge pull request #962 from buberdds/buberdds/wizard
be78435
buberdds added a commit to buberdds/oasis-wallet-web that referenced this pull request Oct 25, 2022
@buberdds
Merge pull request oasisprotocol#962 from buberdds/buberdds/wizard
982e1c3
buberdds pushed a commit to buberdds/oasis-wallet-web that referenced this pull request Oct 26, 2022
@lukaw3d @buberdds
Merge pull request oasisprotocol#962 from buberdds/buberdds/wizard
2c75655
lukaw3d added a commit that referenced this pull request Oct 26, 2022
@lukaw3d
Merge pull request #962 from buberdds/buberdds/wizard
e728870
@lukaw3d lukaw3d mentioned this pull request Apr 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaw3d lukaw3d lukaw3d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@buberdds @lukaw3d