ParaTimes: unit tests #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buberdds
changed the title
buberdds
force-pushed
the
paratimes-ui-3
branch
from
adaf257
to
70e8f16
Compare
buberdds
force-pushed
the
paratimes-ui-3
branch
2 times, most recently
from
a0e975d
to
8795a89
Compare
buberdds
force-pushed
the
paratimes-ui-3
branch
4 times, most recently
from
889c39f
to
e9ba2a9
Compare
lukaw3d
approved these changes
Sep 1, 2022
| render(<TransactionAmount />) | ||
|
|
||
| userEvent.click(screen.getByRole('button', { name: 'MAX' })) | ||
| expect(setTransactionForm).toHaveBeenCalledWith(expect.objectContaining({ amount: '1' })) |
There was a problem hiding this comment.
Can you add precision tests with 1563114365108133939632n
There was a problem hiding this comment.
2493300888889 isn't enough :D js numbers have that precision
There was a problem hiding this comment.
updated in the second PR
buberdds
force-pushed
the
paratimes-ui-3
branch
from
9bd5dd3
to
e429e47
Compare
Merged
buberdds
added a commit
to buberdds/oasis-wallet-web
that referenced
this pull request
Oct 25, 2022
lukaw3d
added a commit
that referenced
this pull request
Oct 25, 2022
buberdds
added a commit
to buberdds/oasis-wallet-web
that referenced
this pull request
Oct 25, 2022
buberdds
pushed a commit
to buberdds/oasis-wallet-web
that referenced
this pull request
Oct 26, 2022
lukaw3d
added a commit
that referenced
this pull request
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests around
react-i18nextin a few tests to validate conditional interpolationPR adds: