Feature/pr 660/nrps acs lti commands #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriloma
requested review from
yukipastelcat,
dresha-dev,
bziondik,
Dang3rZone,
jsconan and
oatymart
yukipastelcat
approved these changes
Aug 26, 2021
There was a problem hiding this comment.
Looks good to me👍
- Fix versions field on Jira ticket is correct (if applicable)
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Documentation updated (if applicable)
- Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
Dang3rZone
approved these changes
Aug 26, 2021
There was a problem hiding this comment.
good job
- Fix versions field on Jira ticket is correct (if applicable)
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Documentation updated (if applicable)
- Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://oat-sa.atlassian.net/browse/PR-660
Description: Implement devkit endpoints to create and delate NRPS memeberships and ACS assessments.
Devkit API: https://oat-sa.github.io/doc-lti1p3/devkit/doc/api/