Fix/lsi 2047/logout button #324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 23, 2023 19:13
…ut switch to template renderer
Codecov Report
@@ Coverage Diff @@
## develop #324 +/- ##
=============================================
- Coverage 13.36% 13.19% -0.17%
- Complexity 269 270 +1
=============================================
Files 22 22
Lines 868 879 +11
=============================================
Hits 116 116
- Misses 752 763 +11
|
Version
There are 0 BREAKING CHANGE, 0 feature, 0 fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://oat-sa.atlassian.net/browse/LSI-2047
The main idea of this is to hide the logout button when you are at the diagnostic tool entry point - the button shouldn't show on the login form.
However, during investigation, it was also seen that cookies (depending on which either login form shown, or the index page of the diag tool) are not removed when pressing logout button. So, it was decided to also fix this small issue.
Changes done in smallest-effort/smallest-changes style.