Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve compact() undefined variable issue #213

Merged
merged 3 commits into from
Mar 15, 2023

Conversation

tikhanovichA
Copy link
Contributor

@tikhanovichA tikhanovichA commented Mar 15, 2023

AUT-2884

Description

For cases when compact(): Undefined variable generates 500 on the PHP level. Now it happens only if we have cases when add or remove variable is empty. The class will be moved if you will see 500, but ACL will be not applied.

Note:
https://www.php.net/manual/en/function.compact.php
Before PHP 7.3, any strings that are not set will silently be skipped.

Changelog

  • fix: Fix default values for $add and $remove variables

image

@github-actions
Copy link

Version

Target Version 7.7.9
Last version 7.7.8

There are 0 BREAKING CHANGE, 0 feature, 3 fixes

Copy link
Contributor

@Karol-Stelmaczonek Karol-Stelmaczonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

Copy link
Contributor

@bartlomiejmarszal bartlomiejmarszal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Checklist

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic
  • Changelog is updated according to changes (if applicable)
  • Documentation is updated according to changes (if applicable)

@tikhanovichA tikhanovichA merged commit 11da5b9 into develop Mar 15, 2023
@tikhanovichA tikhanovichA deleted the fix/AUT-2884/solve-undefined-variable-issue branch March 15, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants