Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/tr 3390 remove calculator related arabic translations #2178

Merged

Conversation

btamas
Copy link
Contributor

@btamas btamas commented Jan 19, 2022

Related to https://oat-sa.atlassian.net/browse/TR-3390

It integrates the new version of qti test runner, where calculator plugin direction is forced to LTR (oat-sa/tao-test-runner-qti-fe#465) and translation is generated, because calculator translations were removed in oat-sa/tao-core#3342

Copy link
Contributor

@svoronuk svoronuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM. Do not forget to update dependency later

Copy link
Contributor

@oatymart oatymart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go as soon as the branch reference is updated.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Documentation is updated according to changes (if applicable)

…ns' of github.com:oat-sa/extension-tao-testqti into fix/TR-3390_remove-calculator-related-arabic-translations
@btamas btamas merged commit 2cf8cd3 into develop Jan 21, 2022
@btamas btamas deleted the fix/TR-3390_remove-calculator-related-arabic-translations branch January 21, 2022 13:26
@github-actions
Copy link

Version

Target Version 44.1.0
Last version 44.0.1

There are 0 BREAKING CHANGE, 2 features, 0 fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants