Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump to php 8.0.0 and remove old nd unsupported dependency versions #166

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

kochen
Copy link
Contributor

@kochen kochen commented Oct 5, 2023

No description provided.

@kochen
Copy link
Contributor Author

kochen commented Dec 4, 2023

@wazelin could you also check this one?

Copy link
Member

@wazelin wazelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will be released as a breaking change (v7) I suppose.
I will make additional releases for dependent libraries, bumping the core library dependency version afterwards then. If you feel like it, @kochen, opening PRs and bumping the core-library dependencies on the following repos will help:

But again, only if you feel doing so. Otherwise, I'll handle it a bit later.

composer.json Outdated
"psr/http-message": "^1.0",
"psr/http-server-handler": "^1.0",
"psr/log": "^1.0 || ^2.0 || ^3.0",
"ramsey/uuid": "^3.9 || ^4"
"psr/log": "^2.0 || ^3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave the older psr/log here for migration reasons as well.

Suggested change
"psr/log": "^2.0 || ^3.0",
"psr/log": "^1.0 || ^2.0 || ^3.0",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wazelin no problem.

if we already bump versions, I'll revise this one, cause PHP 8.0 is also EOL (by now).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left 8.0 for now, but added 8.3

@kochen
Copy link
Contributor Author

kochen commented Dec 8, 2023

@wazelin all yours #171

Copy link
Member

@wazelin wazelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, @kochen!

I'm in favor of fully replacing this PR with #165. It will require a few additional steps, though. More details in #165 (review).

@wazelin wazelin dismissed their stale review December 18, 2023 13:31

Replacing with a different comment

@wazelin wazelin merged commit 318b75a into oat-sa:master Dec 22, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants