Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix/TR-5000/eliminate-label-november-release #444

Conversation

shaveko
Copy link
Contributor

@shaveko shaveko commented Dec 16, 2022

related to https://oat-sa.atlassian.net/browse/TR-5000

Description

Update extension-tao-itemqti to 29.14.4.6 which contains the fix to described issue

How to test

Check the ja-JP label doesnt break into 2 lines in eliminable choices choice interaction

@github-actions
Copy link

github-actions bot commented Dec 16, 2022

Summary 8.0

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
3342 3315 23 4
  1. taoDeliveryRdf/test/unit/model/DataStore/ProcessDataServiceTest.php:42
    testProcess ParseError : syntax error, unexpected variable "$files"
  2. taoQtiItem/test/unit/model/flyExporter/simpleExporter/ItemExporterTest.php:61
    testSetCorrectQTIVersion ParseError : syntax error, unexpected variable "$files"
  3. taoQtiItem/test/unit/model/qti/ItemTest.php:77
    testToQTI common_ext_MissingExtensionException : taoQtiItem not found but required for taoQtiItem
  4. taoQtiItem/test/unit/model/qti/ItemTest.php:104
    testToQTIWithDirAttributeInItemBody common_ext_MissingExtensionException : taoQtiItem not found but required for taoQtiItem

@github-actions
Copy link

Summary 7.4

🔗 Coverage report

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
3342 3317 23 2
  1. vendor/phpunit/phpunit/phpunit:97
    testToQTI common_ext_MissingExtensionException : taoQtiItem not found but required for taoQtiItem
  2. vendor/phpunit/phpunit/phpunit:97
    testToQTIWithDirAttributeInItemBody common_ext_MissingExtensionException : taoQtiItem not found but required for taoQtiItem

@shaveko shaveko requested a review from siwane December 16, 2022 12:20
@github-actions
Copy link

Summary 8.1

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
1703 1681 13 9
  1. tao/test/unit/helpers/form/Decorator/ElementDecoratorTest.php:86
    testGetters Error : Call to undefined method ReflectionUnionType::getName()
  2. taoDacSimple/test/unit/model/DataBaseAccessTest.php:108
    testGetUsersWithPermissions with data set #​0 Error : Call to undefined method ReflectionUnionType::getName()
  3. taoDacSimple/test/unit/model/DataBaseAccessTest.php:108
    testGetUsersWithPermissions with data set #​1 Error : Call to undefined method ReflectionUnionType::getName()
  4. taoDacSimple/test/unit/model/DataBaseAccessTest.php:108
    testGetUsersWithPermissions with data set #​2 Error : Call to undefined method ReflectionUnionType::getName()
  5. taoDacSimple/test/unit/model/DataBaseAccessTest.php:157
    testGetPermissions with data set #​0 Error : Call to undefined method ReflectionUnionType::getName()
  6. taoDacSimple/test/unit/model/DataBaseAccessTest.php:157
    testGetPermissions with data set #​1 Error : Call to undefined method ReflectionUnionType::getName()
  7. taoDeliveryRdf/test/unit/model/DataStore/ProcessDataServiceTest.php:42
    testProcess Error : Call to undefined method ReflectionUnionType::getName()
  8. taoQtiItem/test/unit/model/flyExporter/simpleExporter/ItemExporterTest.php:61
    testSetCorrectQTIVersion Error : Call to undefined method ReflectionUnionType::getName()
  9. taoQtiItem/test/unit/model/qti/ItemTest.php:77
    testToQTI common_ext_MissingExtensionException : taoQtiItem not found but required for taoQtiItem
  10. taoQtiItem/test/unit/model/qti/ItemTest.php:104
    testToQTIWithDirAttributeInItemBody common_ext_MissingExtensionException : taoQtiItem not found but required for taoQtiItem

Copy link
Contributor

@jsconan jsconan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok. However, the lock file contains way more than what is expected. I suggest scoping the update to only the updated extension to avoid side effects. Unless it is expected to update the libraries as well.

@shaveko
Copy link
Contributor Author

shaveko commented Dec 19, 2022

It looks ok. However, the lock file contains way more than what is expected. I suggest scoping the update to only the updated extension to avoid side effects. Unless it is expected to update the libraries as well.

Sounds reasonable, thanks!

updated composer.lock

@shaveko
Copy link
Contributor Author

shaveko commented Dec 19, 2022

I will address this change in a separate PR #445

@shaveko shaveko closed this Dec 19, 2022
@wazelin wazelin deleted the hotfix/TR-5000/eliminate-label-november-release branch April 13, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants