Fix/ADF-1166/ESlint errors in tests of core #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version
There are 0 BREAKING CHANGE, 0 feature, 0 fix |
Coverage Report
|
oatymart
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
Super job!
I ran the new tests once against the old src (this branch), and also against the new src (integration branch).
It's still possible to get a timeout sometimes (core/tokenHandler, core/timer...) but I think this was the case before, and isn't related to code style fixes.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
| @@ -110,6 +110,7 @@ define([ | |||
| }) | |||
| .catch(function(err) { | |||
| assert.ok(false, 'The promise should not be rejected'); | |||
| // eslint-disable-next-line | |||
There was a problem hiding this comment.
Note for future: you can also put /* eslint-disable no-console */ at the top of such files, if it's too repetitive.
There was a problem hiding this comment.
Good point! I should have think of it instead of looking at my fingers 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://oat-sa.atlassian.net/browse/ADF-1166
Summary
Fix the ESLint error in the unit tests for
tao-core.Note: as the changes are pretty heavy, I split them all into several pull requests.
Details
This pull request only targets the
core/*part of the library.The full picture can be seen from the main branch which contains all the fixes: https://github.com/oat-sa/tao-core-sdk-fe.git#fix/ADF-1166/eslint-errors
What has been made:
eslint --fix, then adjust the changes in case by case (mostly string literals).apply())varbyconstorlet(but not in all places, only in the touched files when it was not adding too much noise)How to test
npm inpm run lint:test, errors and warnings coming from thecorefolder should have gone.npm run test core"@oat-sa/tao-core-sdk": "https://github.com/oat-sa/tao-core-sdk-fe.git#fix/ADF-1166/eslint-errors",, then checking the unit tests and playing with TAO