feat: RDF Object Mapper PoC #3447
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectoras
force-pushed
the
experimental/rdf-object-mapper
branch
from
d8e46fc
to
4f782b5
Compare
Version
There are 0 BREAKING CHANGE, 1 feature, 0 fix |
hectoras
commented
Sep 5, 2022
Comment on lines
+25
to
+27
| public const URI = 1; | ||
| public const LABEL = 2; | ||
| public const COMMENT = 3; |
There was a problem hiding this comment.
Having only LITERAL (for copying values as-is) and RESOURCE (for URIs pointing to other resources) may suffice.
The former values types here were matching exactly the fields used for the PoC (basically attributes currently found in core_kernel_classes_Resource; as well as having a URI type to hold resource URIs (for example, URIs used as primary identifiers for resources).
This may be combined with PHP 7.4+ property type hints as well to validate things like conversions to integer etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Jira issue: ADF-1174