Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ensure exit fail on timeout #16

Merged
merged 6 commits into from
Dec 12, 2019
Merged

Conversation

krampstudio
Copy link
Contributor

  • Fix the exit code when a test fails in timeout
  • Run all tests even if one is in timeout
  • Adapt the display in case of test in timeout

How to test :

  • npm test
  • Within a repository that has tests that fails or in timeout (async not done)

Copy link
Contributor

@btamas btamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but if you run with verbose report, the timeouted test has no result.
Run this: node ./bin/qunit-testrunner.js -vvvv

Previously:

exampleTest/timeoutTest/test.html
{ Error: Test run could not finish in 30000ms
    at runQunitPuppeteer.then.catch.e (/Users/tamasbesenyei/work/tao-qunit-testrunner-fe/src/testrunner.js:96:27) path: 'exampleTest/timeoutTest/test.html' }

Now:

exampleTest/timeoutTest/test.html

@btamas btamas merged commit 7b714a1 into develop Dec 12, 2019
@btamas btamas deleted the fix/ensure-exit-fail-on-timeout branch December 12, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants