Use name pointer for internal type identification #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please change target branch to |
FlorianRhiem
changed the base branch from
master
to
data_mapping_type_id_refactoring
CMake support
Fix typo in CMakeLists.txt
Instead of relying on a pointer to a string literal, types are now identified using a constexpr pointer to a static, non-constexpr member that contains the actual string.
FlorianRhiem
force-pushed
the
feature-nameptr
branch
from
aa85d6a
to
1de2a32
Compare
|
Fixed in #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible solution to the problem with
CLASS_NAMEs in shared libraries discussed in #7. Types have the string as a non-constexprstatic member and have a pointer to that static member as theconstexprthat is used in comparisons etc. This way you have both a human-readable representation and aconstexpr, with the difference that it must work thanks to the one definition rule.A few things you might want to do differently to this branch:
namePtrtoTypeand kept thenamefor the sake of simplicity. If you don't want to waste the memory of keepingnamearound, it could be a method that simply dereferencesnamePtr.CLASS_NAMEand called the non-constexprstringCLASS_NAME_NONCONSTEXPR.CLASS_NAMEPTRandCLASS_NAMEmight be better names, but they would require larger changes to the existing code.