feat: add SD-JWT VC Type Metadata #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfett
reviewed
Mar 26, 2024
danielfett
reviewed
Mar 26, 2024
danielfett
reviewed
Mar 26, 2024
danielfett
approved these changes
Mar 26, 2024
awoie
changed the title
Co-authored-by: Daniel Fett <fett@danielfett.de>
OR13
reviewed
Mar 30, 2024
Yep, good point. I18N is definitely needed although I'm not too sure about name/description since those are intended for developers only, not for end-users. I'll create a ticket to consider I18N, and also discuss whether this is needed for dev-only fields. I18N is definitely something we should add to metadata but needed some PR to start with first. |
bc-pi
reviewed
Apr 2, 2024
bc-pi
reviewed
Apr 2, 2024
bc-pi
reviewed
Apr 2, 2024
bc-pi
reviewed
Apr 2, 2024
bc-pi
reviewed
Apr 2, 2024
Co-authored-by: Brian Campbell <71398439+bc-pi@users.noreply.github.com>
bc-pi
approved these changes
Apr 2, 2024
c2bo
reviewed
Apr 5, 2024
c2bo
approved these changes
Apr 5, 2024
|
We have 3 approvals and no new comments coming in after 2 weeks. I propose to merge this PR @bc-pi @danielfett . PR was created 1 month ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add general SD-JWT VC Type Metadata framework based on @danielfett work: https://vcstuff.github.io/sd-jwt-vc-types/draft-fett-oauth-sd-jwt-vc-types.html
See preview here:
https://drafts.oauth.net/oauth-sd-jwt-vc/awoie/feat-metadata/draft-ietf-oauth-sd-jwt-vc.html
Fixes #181, #171