Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow a redirect with different host, but same path #153

Merged
merged 1 commit into from
Jan 20, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/oauth/consumer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,14 @@ def token_request(http_method, path, token = nil, request_options = {}, *argumen
when (300..399)
# this is a redirect
uri = URI.parse(response['location'])
response.error! if uri.path == path # careful of those infinite redirects
our_uri = URI.parse(site)

if uri.path == path && our_uri.host != uri.host
options[:site] = "#{uri.scheme}://#{uri.host}"
@http = create_http
end

response.error! if uri.path == path && our_uri.host == uri.host # careful of those infinite redirects
self.token_request(http_method, uri.path, token, request_options, arguments)
when (400..499)
raise OAuth::Unauthorized, response
Expand Down
13 changes: 13 additions & 0 deletions test/units/test_consumer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,19 @@ def test_token_request_follows_redirect
assert_equal 'secret', hash[:oauth_token_secret]
end

def test_follow_redirect_different_host_same_path
request_uri = URI.parse("https://example.com/request_token")
redirect_uri = URI.parse("https://foobar.com/request_token")

stub_request(:get, "http://example.com/request_token").to_return(:status => 301, :headers => {'Location' => redirect_uri.to_s})
stub_request(:get, "https://foobar.com/request_token").to_return(:body => "oauth_token=token&oauth_token_secret=secret")

hash = @consumer.token_request(:get, request_uri.path) {{ :oauth_token => 'token', :oauth_token_secret => 'secret' }}

assert_equal 'token', hash[:oauth_token]
assert_equal 'secret', hash[:oauth_token_secret]
end

def test_that_can_provide_a_block_to_interpret_a_request_token_response
@consumer.expects(:request).returns(create_stub_http_response)

Expand Down