-
Notifications
You must be signed in to change notification settings - Fork 621
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Stuck at 0.58 until rubies < 2.2 are dropped
- Loading branch information
Showing
1 changed file
with
4 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0267903
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont think we need to bother with ruby <=2.1 for the unreleased 2.0 version of this gem.
that's my opinion at least.
2.2 is out of support for almost 6 months already.
and 2.3 will go out of support in 6 months as well...
0267903
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are good points, but due to various issues the next release will not be dropping support for any currently supported versions. The primary issue is: this a widely deployed gem, and it has many gems that have it as a dependency, and some of them may want to upgrade to latest faraday, and not be ready to drop support yet. This gem missed out on a lot of important OAuth updates over the years, and there should be one final release that allows older installations to upgrade. The follow up release will drop support for old versions of Ruby. See milestone descriptions for details.