Skip to content

Commit

Permalink
Stuck at 0.58 until rubies < 2.2 are dropped
Browse files Browse the repository at this point in the history
  • Loading branch information
pboling committed Sep 10, 2018
1 parent 8b073a5 commit 0267903
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
group :test do
ruby_version = Gem::Version.new(RUBY_VERSION)
if ruby_version >= Gem::Version.new('2.1')
gem 'rubocop', '~> 0.59.0'
# TODO: Upgrade to >= 0.59 when we drop Rubies below 2.2
# Error: Unsupported Ruby version 2.1 found in `TargetRubyVersion` parameter (in .rubocop.yml). 2.1-compatible analysis was dropped after version 0.58.
# Supported versions: 2.2, 2.3, 2.4, 2.5
gem 'rubocop', '~> 0.58.0'
gem 'rubocop-rspec', '~> 1.29.0'
end
gem 'pry', '~> 0.11' if ruby_version >= Gem::Version.new('2.0')
Expand Down

2 comments on commit 0267903

@mathieujobin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think we need to bother with ruby <=2.1 for the unreleased 2.0 version of this gem.

that's my opinion at least.

2.2 is out of support for almost 6 months already.
and 2.3 will go out of support in 6 months as well...

@pboling
Copy link
Member Author

@pboling pboling commented on 0267903 Sep 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are good points, but due to various issues the next release will not be dropping support for any currently supported versions. The primary issue is: this a widely deployed gem, and it has many gems that have it as a dependency, and some of them may want to upgrade to latest faraday, and not be ready to drop support yet. This gem missed out on a lot of important OAuth updates over the years, and there should be one final release that allows older installations to upgrade. The follow up release will drop support for old versions of Ruby. See milestone descriptions for details.

Please sign in to comment.