Core: Node API was not calling right method

[tooppaaa]

No description provided.

[tooppaaa]

Previous one was merged a bit too fast ;)

[obahareth]

@tooppaaa We should release a new version for this I assume, right? 2.0.1?
Sorry for the fast merge before, I am a bit flooded with work at the moment and I thought the repo in the state it was before was blocking you from using as a library so I wanted to cooperate fast. I will do more thorough reviews from now on.

[obahareth]

By the way @tooppaaa can you share your npmjs.com username with me? I'd like to add you to the package on there as well.

[tooppaaa]

Hey @obahareth no worries :)
My username is the same as github: tooppaaa

Yes, we can release :)

[varoot]

Can we release this and also update the documentation on README to remove reference to result.es6Modules?

[tooppaaa]

@varoot Sorry I didn't get (saw !?) a notification when I was added to npm for this package.
This is (should) be deployed.

Could you please let me know as it's my first time publishing this package if it's all good on your side ?
Thanks a lot !!

[varoot]

Could you please let me know as it's my first time publishing this package if it's all good on your side ?

@tooppaaa Yep. It's working now. Thanks a lot!

[obahareth]

Can we release this and also update the documentation on README to remove reference to result.es6Modules?

@tooppaaa @varoot I'm a little confused on this part, I think we need this? The functions that build the regex expect an array of strings and that should be result.es6Modules, no? Because result is just an object, e.g. see #39 (which isn't released yet, but perhaps we'll change it to match what's expected here to avoid breaking anything).

[varoot]

Hmm... I think there must be another PR to change this behavior. Previously it was returning array of strings.