-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Node API was not calling right method #41
Conversation
Previous one was merged a bit too fast ;) |
@tooppaaa We should release a new version for this I assume, right? |
By the way @tooppaaa can you share your npmjs.com username with me? I'd like to add you to the package on there as well. |
Hey @obahareth no worries :) Yes, we can release :) |
Can we release this and also update the documentation on README to remove reference to |
@varoot Sorry I didn't get (saw !?) a notification when I was added to npm for this package. Could you please let me know as it's my first time publishing this package if it's all good on your side ? |
@tooppaaa Yep. It's working now. Thanks a lot! |
@tooppaaa @varoot I'm a little confused on this part, I think we need this? The functions that build the regex expect an array of strings and that should be |
Hmm... I think there must be another PR to change this behavior. Previously it was returning array of strings. |
No description provided.