Build libraries with a suffix in the name that specifies the TLS library built against #151

mrdeep1 · 2018-03-08T21:19:55Z

LIBCOAP_API_VERSION is bumped to 2

Depending on the TLS library selection by the ./configure options, the libraries will be named as

libcoap-2-openssl.a
libcoap-2-openssl.so*
libcoap-2-gnutls.a
libcoap-2-gnutls.so*
libcoap-2-tinydtls.a
libcoap-2.a
libcoap-2.so*

Removal of old libcoap-1* files
New libcoap-2.pc.in file
libcoap-2.{map,sym} files are no longer part of git and get built automatically whenever ./configure is run.

Correction of some typos

Options such as '--without-openssl' now work as expected.

New file BUILDING to give an overview as to how to build libcoap

obgm

Very nice! I have found minor nits, and there is the open discussion about the map files we need to resolve first. Otherwise, I am fine with these changes.

obgm · 2018-03-09T09:31:31Z

BUILDING

+# With TinyDTLS
+./configure --enable-tests --disable-documentation --enable-examples --with-tinydtls --disable-shared
+
+# With OpeSSL


Typo: "OpenSSL"

Fixed. Also added in

If you need to rebuild the libcoap-*.{map,sym} files to update any exposed
function changes, run

make update-map-file

prior to running 'make'.

obgm · 2018-03-09T09:40:46Z

autogen.sh

 include/coap/coap.h
 install-sh
-libcoap-1.pc libtool ltmain.sh
+libcoap-2.pc libtool ltmain.sh


Maybe extract this information from LIBCOAP_API_VERSION in configure.ac?

As it is only for deleting files with 'autogen.sh --clean' I have changed it to
+libcoap-*.pc libtool ltmain.sh

Good, thanks!

obgm · 2018-03-09T09:50:36Z

configure.ac

@@ -583,6 +603,7 @@ libcoap configuration summary:
      libcoap package version : "$PACKAGE_VERSION"
      libcoap library version : "$LIBCOAP_SO_VERSION"
      libcoap API version     : "$LIBCOAP_API_VERSION"
+      libcoap DTLS lib ext'n  : "$LIBCOAP_DTLS_LIB_EXTENSION_NAME"


The single ' may break automation scripts. I am not sure if such things exist but maybe we can just be safe by avoiding it?

' is no more

Good, thanks!

obgm · 2018-03-09T09:54:44Z

configure.ac

+#
+# Bring .map / .sym files up to date
+#
+make update-map-file > /dev/null 2>&1


This requires exuberant-ctags which is not always present. I am therefore in favor of keeping the default map files as they should reflect the symbols contained in the stable API and thus do not need to change very often and only by the maintainers.

Please refer to the mailing list for ongoing discussion.

.PHONY does not cause them to get automatically updated / built, it just means that whenever 'make update-map-file' is called, it will always get run, even if there is a file called update-map-file.

When a built library is distributed, the distribution does not need to include the .map/.sym files - they are only used when creating the the library files.

As you are in favor of keeping / maintaining the .map/.sym files, I will revert out that change and re-install the distclean warning.

Yes, correct.

mrdeep1 · 2018-03-09T12:21:45Z

Changes made, as well as adding in stripping out the coap_dtls_, coap_tls_ and coap_socket_* that do not need to be publicly exposed.

mrdeep1 · 2018-04-04T18:10:50Z

Rebased against develop

obgm · 2018-04-11T13:08:38Z

.gitignore

@@ -34,6 +34,11 @@ src/**/.dirstamp
 src/**/.libs/
 src/**/*.o
 src/**/*.lo
+src/*.deps/
+src/*.dirstamp
+src/*.libs/


These files are already covered by the preceding patterns.

mrdeep1 · 2018-04-11T14:08:38Z

Rebased off develop and .gitignore now (I believe) correctly updated.

obgm · 2018-04-12T08:59:21Z

So far, this PR looks good to me. @tijuca, are you ok with the proposed naming of the .pc files (such as libcoap-2-openssl.pc)? This would probably need some guesswork by applications that depend on libcoap.

tijuca · 2018-04-12T16:58:59Z

I've done some quick test builds, looks also good to me.
We might need to change the installation folder of the public headers to /u/l/coap2 so the current tree can be co-installed on the system. Can be done later to not keep the pull requests open longer as needed. This PR is already a big change.

Replace LIBCOAP_API_VERSON with LIBCOAP_NAME_SUFFIX when refering to building the library files. configure.ac defines LIBCOAP_NAME_SUFFIX. libcoap-$LIBCOAP_API_VERSION.{sym,map} remain. Make distclean clean up temporary src/*.o and src/*.lo files which may be left lying around from a previous './configure xxx ; make' that was using a different TLS library. Add in coap_dtls_*, coap_tls_*, coap_socket_* functions that do not need to be publically exposed in the libraries

Update the new LIBCOAP_API_VERSION of the files Include examples/Makefile and tests/Makefile that are built by autogen.sh

Make LIBCOAP_API_VERSION=2 Set LIBCOAP_NAME_SUFFIX to be $LIBCOAP_API_VERSION{-openssl,-gnutls,-tinydtls} as appropriate based on the configure build options. This means that library files will be named libcoap-2-openssl.a libcoap-2-openssl.so* libcoap-2-gnutls.a libcoap-2-gnutls.so* libcoap-2-tinydtls.a libcoap-2.a libcoap-2.so* Fix some typos Use $withval instead of yes so that, say, --without-openssl works as expected.

This is done so we do not need to expose coap_dtls_startup() publically

mrdeep1 · 2018-04-13T07:46:34Z

Updated BUILDING following raising of issue #164

obgm · 2018-04-13T11:15:39Z

Okay, so be it.

obgm requested changes Mar 9, 2018

View reviewed changes

mrdeep1 force-pushed the builds branch from 1d778be to ba9d671 Compare March 9, 2018 12:20

mrdeep1 force-pushed the builds branch from ba9d671 to 46d7a51 Compare April 4, 2018 18:10

obgm reviewed Apr 11, 2018

View reviewed changes

libcoap-2.pc.in: New Packaging file

bed9872

mrdeep1 force-pushed the builds branch from 46d7a51 to f5ac8d7 Compare April 11, 2018 14:06

obgm approved these changes Apr 12, 2018

View reviewed changes

mrdeep1 added 10 commits April 13, 2018 08:43

BUILDING: New file giving an overview of how to build libcoap

b7f1f52

examples/Makefile.am: Update for new libcoap library naming

ef6c72b

tests/Makefile.am: Update for new libcoap library naming

153e4db

.gitignore: Include more interim files to ignore

0ac9bb5

autogen.sh: Update AUTOGEN_FILES= files

2300f94

Update the new LIBCOAP_API_VERSION of the files Include examples/Makefile and tests/Makefile that are built by autogen.sh

libcoap-2.{map,sym}: Add in files

fcf30a6

tests/test_tls.c: Use coap_startup() instead of coap_dtls_startup()

fc0761f

This is done so we do not need to expose coap_dtls_startup() publically

libcoap-1.{map|sym} libcoap-1.pc.in: deleted

653d3f1

mrdeep1 force-pushed the builds branch from f5ac8d7 to 653d3f1 Compare April 13, 2018 07:44

obgm merged commit 576aeac into obgm:develop Apr 13, 2018

mrdeep1 mentioned this pull request Apr 13, 2018

How to make client retransmit its message #163

Closed

mrdeep1 deleted the builds branch April 13, 2018 13:11

mrdeep1 mentioned this pull request Jan 3, 2020

add cmake support to libcoap #430

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build libraries with a suffix in the name that specifies the TLS library built against #151

Build libraries with a suffix in the name that specifies the TLS library built against #151

mrdeep1 commented Mar 8, 2018

obgm left a comment

obgm Mar 9, 2018

mrdeep1 Mar 9, 2018

obgm Mar 9, 2018

mrdeep1 Mar 9, 2018

obgm Mar 9, 2018

obgm Mar 9, 2018

mrdeep1 Mar 9, 2018

obgm Mar 9, 2018

obgm Mar 9, 2018

mrdeep1 Mar 9, 2018

obgm Mar 9, 2018

mrdeep1 commented Mar 9, 2018

mrdeep1 commented Apr 4, 2018

obgm Apr 11, 2018

mrdeep1 commented Apr 11, 2018

obgm commented Apr 12, 2018

tijuca commented Apr 12, 2018

mrdeep1 commented Apr 13, 2018

obgm commented Apr 13, 2018

Build libraries with a suffix in the name that specifies the TLS library built against #151

Build libraries with a suffix in the name that specifies the TLS library built against #151

Conversation

mrdeep1 commented Mar 8, 2018

obgm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mrdeep1 commented Mar 9, 2018

mrdeep1 commented Apr 4, 2018

Choose a reason for hiding this comment

mrdeep1 commented Apr 11, 2018

obgm commented Apr 12, 2018

tijuca commented Apr 12, 2018

mrdeep1 commented Apr 13, 2018

obgm commented Apr 13, 2018