Added lint enum_struct_variant_field_now_doc_hidden

src/lints/enum_struct_variant_field_now_doc_hidden.ron

@@ -0,0 +1,71 @@
+SemverQuery(
+    id: "enum_struct_variant_field_now_doc_hidden",
+    human_readable_name: "pub enum struct variant's field is now #[doc(hidden)]",
+    description: "An enum's struct variant has a field that is now marked #[doc(hidden)] and is thus no longer part of the public API.",
+    required_update: Major,
+    reference_link: Some("https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden"),
+    query: r#"
+    {
+        CrateDiff {
+            baseline {
+                item {
+                    ... on Enum {
+                        visibility_limit @filter(op: "=", value: ["$public"])
+                        enum_name: name @output @tag
+
+                        importable_path {
+                            path @output @tag
+                            public_api @filter(op: "=", value: ["$true"])
+                        }
+
+                        variant {
+                            ... on StructVariant {
+                                variant_name: name @output @tag
+                                public_api_eligible @filter(op: "=", value: ["$true"])
+
+                                field {
+                                    field_name: name @output @tag
+                                    public_api_eligible @filter(op: "=", value: ["$true"])
+                                }
+                            }
+                        }
+                    }
+                }
+            }
+            current {
+                item {
+                    ... on Enum {
+                        visibility_limit @filter(op: "=", value: ["$public"])
+                        name @filter(op: "=", value: ["%enum_name"])
+
+                        importable_path {
+                            path @filter(op: "=", value: ["%path"])
+                        }
+
+                        variant {
+                            ... on StructVariant {
+                                name @filter(op: "=", value: ["%variant_name"])
+                                public_api_eligible @filter(op: "=", value: ["$true"])
+
+                                field {
+                                    public_api_eligible @filter(op: "!=", value: ["$true"])
+                                    name @filter(op: "=", value: ["%field_name"])
+                                    span_: span @optional {
+                                        filename @output
+                                        begin_line @output
+                                    }
+                                }
+                            }
+                        }
+                    }
+                }
+            }
+        }
+    }"#,
+    arguments: {
+        "public": "public",
+        "true": true,
+    },
+    error_message: "A field of a pub enum tuple variant is now marked #[doc(hidden)] and is no longer part of the public API.",
+    per_result_error_template: Some("field {{enum_name}}.{{field_name}} in file {{span_filename}}:{{span_begin_line}}"),
+)

src/query.rs

@@ -469,6 +469,7 @@ macro_rules! add_lints {
 }
 
 add_lints!(
+    enum_struct_variant_field_now_doc_hidden,
     enum_tuple_variant_field_now_doc_hidden,
     trait_method_now_doc_hidden,
     auto_trait_impl_removed,

test_crates/enum_struct_variant_field_now_doc_hidden/new/Cargo.toml

@@ -0,0 +1,7 @@
+[package]
+publish = false
+name = "enum_struct_variant_field_now_doc_hidden"
+version = "0.1.0"
+edition = "2021"
+
+[dependencies]

test_crates/enum_struct_variant_field_now_doc_hidden/new/src/lib.rs

@@ -0,0 +1,33 @@
+// should not be caught since field was already marked #[doc(hidden)]
+pub enum PublicEnum {
+    StructVariant {
+        #[doc(hidden)]
+        x: i64,
+        y: u8,
+    },
+}
+//Basic Test case should be caught
+pub enum PublicEnumA {
+    StructVariant {
+        #[doc(hidden)]
+        x: i64,
+        y: u8,
+    },
+}
+// Non Public Enum should not be affected on adding #[doc(hidden)]
+enum NonPublicEnum {
+    StructVariant {
+        #[doc(hidden)]
+        x: i32,
+        y: u8,
+    },
+}
+//should not be caught since enum was not a part of public API
+#[doc(hidden)]
+pub enum PublicEnumB {
+    StructVariant {
+        #[doc(hidden)]
+        x: i32,
+        y: i64,
+    },
+}

test_crates/enum_struct_variant_field_now_doc_hidden/old/Cargo.toml

@@ -0,0 +1,7 @@
+[package]
+publish = false
+name = "enum_struct_variant_field_now_doc_hidden"
+version = "0.1.0"
+edition = "2021"
+
+[dependencies]

test_crates/enum_struct_variant_field_now_doc_hidden/old/src/lib.rs

@@ -0,0 +1,17 @@
+pub enum PublicEnum {
+    StructVariant {
+        #[doc(hidden)]
+        x: i64,
+        y: u8,
+    },
+}
+pub enum PublicEnumA {
+    StructVariant { x: i64, y: u8 },
+}
+enum NonPublicEnum {
+    StructVariant { x: i32, y: u8 },
+}
+#[doc(hidden)]
+pub enum PublicEnumB {
+    StructVariant { x: i32, y: i64 },
+}

test_outputs/enum_struct_variant_field_now_doc_hidden.output.ron

@@ -0,0 +1,28 @@
+{
+    "./test_crates/enum_now_doc_hidden/": [
+        {
+            "enum_name": String("PublicEnumHiddenStructFieldOnVariant"),
+            "field_name": String("a"),
+            "path": List([
+                String("enum_now_doc_hidden"),
+                String("PublicEnumHiddenStructFieldOnVariant"),
+            ]),
+            "span_begin_line": Uint64(78),
+            "span_filename": String("src/lib.rs"),
+            "variant_name": String("A"),
+        },
+    ],
+    "./test_crates/enum_struct_variant_field_now_doc_hidden/": [
+        {
+            "enum_name": String("PublicEnumA"),
+            "field_name": String("x"),
+            "path": List([
+                String("enum_struct_variant_field_now_doc_hidden"),
+                String("PublicEnumA"),
+            ]),
+            "span_begin_line": Uint64(13),
+            "span_filename": String("src/lib.rs"),
+            "variant_name": String("StructVariant"),
+        },
+    ],
+}