Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong character encoding when reading data from R server #3785

Closed
ymarcon opened this issue Mar 30, 2023 · 1 comment
Closed

Wrong character encoding when reading data from R server #3785

ymarcon opened this issue Mar 30, 2023 · 1 comment
Assignees
@ymarcon
Labels
bug

Comments

@ymarcon
Copy link
Member

ymarcon commented Mar 30, 2023

Opal 4.4 is not reading JSON data received from Rock with the UTF-8 encoding. Affects Opal 4.4 only, not 4.5.
@ymarcon
Copy link
Member Author

ymarcon commented Mar 30, 2023 •
edited

It appears that the Spring 4 (used by Opal 4.4) class StringHttpMessageConverter uses the default charset ISO-8859-1. This has been fixed in Spring 5 (used by Opal 4.5), where StringHttpMessageConverter uses UTF-8 charset when the content type is application/json.

Ideally it should be Rock to specify the charset in the response headers: Content-Type: application/json;charset=utf-8.

ymarcon added a commit that referenced this issue Mar 30, 2023
@ymarcon
#3785 Specify explicitly utf-8 as the default charset for StringHttpM…
8d549c6 
…essageConverter
@ymarcon ymarcon self-assigned this Mar 30, 2023
@ymarcon ymarcon added the bug label Mar 30, 2023
@ymarcon ymarcon closed this as completed Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ymarcon ymarcon

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ymarcon