Skip to content

Commit

Permalink
drop rule #8, related more to DDD, can vary a lot
Browse files Browse the repository at this point in the history
  • Loading branch information
TomasVotruba committed Apr 9, 2017
1 parent a90cffb commit d3eb237
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 240 deletions.
6 changes: 5 additions & 1 deletion README.md
Expand Up @@ -3,7 +3,6 @@
[![Build Status](https://img.shields.io/travis/object-calisthenics/phpcs-calisthenics-rules.svg?style=flat-square)](https://travis-ci.org/object-calisthenics/phpcs-calisthenics-rules)
[![Code Coverage](https://img.shields.io/scrutinizer/coverage/g/object-calisthenics/phpcs-calisthenics-rules.svg?style=flat-square)](https://scrutinizer-ci.com/g/object-calisthenics/phpcs-calisthenics-rules)
[![Downloads](https://img.shields.io/packagist/dt/object-calisthenics/phpcs-calisthenics-rules.svg?style=flat-square)](https://packagist.org/packages/object-calisthenics/phpcs-calisthenics-rules)
[![PHPStan](https://img.shields.io/badge/PHPStan-enabled-brightgreen.svg?style=flat-square)](https://github.com/phpstan/phpstan)

Object Calisthenics are **set of rules in object-oriented code, that focuses of maintainability, readability, testability and comprehensibility**.

Expand Down Expand Up @@ -238,6 +237,11 @@ For other cases, e.g. email, you can **deal with that in your [Domain via Value

This rule makes sense, yet is too strict to be useful in practise. Even our code didn't pass it at all.

### 8. Do Not Use Classes With More Than Two Instance Variables

[Read explanation with code examples](http://williamdurand.fr/2013/06/03/object-calisthenics/#8-no-classes-with-more-than-two-instance-variables)



## 3 Rules for Contributing

Expand Down

This file was deleted.

7 changes: 0 additions & 7 deletions src/ObjectCalisthenics/ruleset.xml
Expand Up @@ -60,13 +60,6 @@
</properties>
</rule>

<!-- 8. Do Not Use Classes With More Than Two Instance Variables -->
<rule ref="ObjectCalisthenics.CodeAnalysis.InstancePropertyPerClassLimit">
<properties>
<property name="maxCount" value="2"/>
</properties>
</rule>

<!-- 9. Do not Use Getters and Setters -->
<rule ref="ObjectCalisthenics.Classes.ForbiddenPublicProperty">
<properties>
Expand Down
145 changes: 0 additions & 145 deletions tests/Sniffs/CodeAnalysis/InstancePropertyPerClassLimitSniffTest.inc

This file was deleted.

This file was deleted.

0 comments on commit d3eb237

Please sign in to comment.