Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back class doc comment check #4

Closed
guilhermeblanco opened this issue Aug 21, 2014 · 1 comment
Closed

Bring back class doc comment check #4

guilhermeblanco opened this issue Aug 21, 2014 · 1 comment

Comments

@guilhermeblanco
Copy link
Contributor

It seems class doc comment processing was failing with the usage of Doctrine annotations.
We gotta fix it and turn back on.
nubs added a commit to nubs/phpcs-calisthenics-rules that referenced this issue Jan 25, 2016
@nubs
Add the missing word "one" to Rule object-calisthenics#4.
7b9b3a7
EmanueleMinotto added a commit that referenced this issue Jan 26, 2016
@EmanueleMinotto
Merge pull request #26 from nubs/patch-1
3794636 
Add the missing word "one" to Rule #4.
@TomasVotruba
Copy link
Contributor

Is probably fixed, please reopen if still and issue with deeper description or failing test the best.

TomasVotruba added a commit that referenced this issue Mar 3, 2017
@TomasVotruba
drop rule #4, too strict
0fdc125
TomasVotruba added a commit that referenced this issue Mar 3, 2017
@TomasVotruba
drop rule #4, too strict
6a996d9
TomasVotruba pushed a commit that referenced this issue Mar 3, 2017
Merge pull request #45 from object-calisthenics/drop-crazy-strict-rules
44e2b87 
Drop rule #4, it is way too strict in practise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guilhermeblanco @TomasVotruba