Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Composer package type to phpcodesniffer-standard #63

Merged
merged 1 commit into from
May 14, 2017
Merged

Changed Composer package type to phpcodesniffer-standard #63

merged 1 commit into from
May 14, 2017

Conversation

frenck
Copy link
Contributor

@frenck frenck commented May 11, 2017

Problem/Motivation

Composer allows declaring the type of a package. When no
type is declared, the default is "library".

There are various composer plugins that can install custom
PHP CodeSniffer standards:

For these installers to work, the package type needs to be set to "phpcodesniffer-standard".

There are also a lot of packages that adhere to this type.

Proposed changes

Adding the following line to the composer.json will make it possible for such packages to install this custom sniff using composer:

    "type" : "phpcodesniffer-standard"

This will in no way change the existing behaviour of this package for users that do not include one of the packages mentioned above in their projects composer.json.

Possible future steps

  • Update documentation
  • Require an installer plugin by default
  • Update Travis builds

@TomasVotruba
Copy link
Contributor

Hey @frenck

Very nice written. Thanks for taking the time to make such a clear summary.

I don't like adding useles content to the composer.json, so it's easy to read ever for less composer-cool-features-familar developes, but this is rather reasonable.

I'm 👍 on this.

@TomasVotruba TomasVotruba merged commit 413300f into object-calisthenics:master May 14, 2017
@TomasVotruba
Copy link
Contributor

Thank you, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants