Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - property query dart26 #58

Closed
wants to merge 70 commits into from
Closed

WIP - property query dart26 #58

wants to merge 70 commits into from

Conversation

Buggaboo
Copy link
Contributor

@Buggaboo Buggaboo commented Oct 25, 2019 •
edited

I need suggestions for fixing #70

Buggaboo and others added 18 commits October 23, 2019 20:54
@Buggaboo
At least it's compiling
b4298ba
@Buggaboo
* Changed package visibility (due to the generic argument constraint,…
2e7fcb1 
… e.g. "<T extends Base>")

* Replaced propertyX with generic property method (with auto-type inference)
* Added default to find functions, should the default arg value be 0
  or should the address be 0 for NULL? It would be nice to see the actual (closed) source code
  in this "open" source project.
@Buggaboo
Fixed confused nullptr implementation (aka undefined default value) f…
ab4ac49 
…or find
@Buggaboo
simplify literal string concatenation
0b74bfc
@Buggaboo
Added more tests, some tests are returning == OBX_ERROR_ILLEGAL_ARGUM…
472e9c0 
…ENT 10002
@Buggaboo
modified tests, added new tests, added more constraints
4eb1f33
@Buggaboo
added another basic query .count test
137bbf6
@vaind
print-out model.json into the generated file to avoid loading it at r…
5d1fe7a 
…untime
@vaind
correct native error message building
c13c616
@Buggaboo
updated deps
dddcc97
@Buggaboo
Struct no longer takes a generic arg
f421734
@Buggaboo
Replaced Pointer allocate / free with package:ffi's allocate and free
87542db 
We could have used extension methods to fix it without changing too many
lines of code
@Buggaboo
replace load/store with value
3cabbfe 
replace allocate/free with package:ffi's
@Buggaboo
added ref, so it seems that ref is being autogenerated
37de6e1
@Buggaboo
prefixed ffi for a nameclash
47255dc 
used asTypedList properly
@Buggaboo
fixed other struct issues
1499ec3
@Buggaboo
fixed utf8 frees, not 100% sure this is correct,
2cad369 
since there is no clear connection between the alloc of Uint8 and the Utf8 Struct

At least we can generate, compile, run all the tests
@Buggaboo
Merge branch 'dev-dart26' into query-property-dev-dart26
20fcc56
@Buggaboo Buggaboo changed the title WiP: Query property dev dart26 WiP: property query dart26 Oct 25, 2019
@Buggaboo Buggaboo changed the title WiP: property query dart26 WIP - property query dart26 Oct 25, 2019
vaind and others added 27 commits October 30, 2019 15:24
@vaind
move integration test TODO out of the docs section
1308142
@nalenz-objectbox
Remove objectbox-model.json asset from objectbox_demo
bbd6c14
@nalenz-objectbox
Prevent adding empty notes in objectbox_demo
1cd200a
@nalenz-objectbox
Fix date handling in Flutter demo
2dc1c0e
@nalenz-objectbox
Fix putMany test case
d4ffb1e
@nalenz-objectbox
Add test case for 64 bit integer limits (objectbox#63)
b2dc25b
@vaind
rename objectbox_model_generator to objectbox_generator
48852e5
@vaind
generator - prepare for publishing
67993ca
@vaind
exclude the example folder from code generation by default
2d99df1
@vaind
Merge pull request objectbox#64 from objectbox/63-test-integer-limits
fafde37 
Test integer limits
@vaind
rework readme
98208af
@vaind
remove query/index.dart in favor of query/query.dart
d426c8f
@nalenz-objectbox
Remove test index.dart
a2efdbf
@vaind
reorganize a query test to be more readable
fa51c1f
@vaind
handle box.remove() not-found without catching exceptions
b571130
@nalenz-objectbox
Add test for null properties
6b89922
@nalenz-objectbox
Merge pull request objectbox#67 from objectbox/65-test-null-properties
32f6984 
Test null values for entity properties
@vaind
fix generator test runner after a dependency update
5547411
@vaind
Merge remote-tracking branch 'origin/dev' into dev
93759ce
@vaind
doc: add build_runner info to the readme
e481959
@vaind
prepare v0.4.0
76ee673
@vaind
Merge pull request objectbox#60 from objectbox/dev
80cca76 
v0.4.0 release
@Buggaboo
Merge branch 'dev' into dev-dart26
4621b38
@Buggaboo
Merge branch 'dev-dart26' into query-property-dev-dart26
443d589
@Buggaboo
min max sum fixed
1abac13 
everything else (e.g. count) is still horribly broken
@Buggaboo
add .sum .min .max test for floats
fd58df0
@Buggaboo
.find's result array
a5c0a71 
seems to return a result before the search is actually concluded,
there is some non-deterministic behavior here
@Buggaboo Buggaboo mentioned this pull request Nov 5, 2019
Closed
@vaind vaind closed this Nov 15, 2019
@FredJul FredJul mentioned this pull request Sep 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Buggaboo @vaind @nalenz-objectbox